Fix crash on API queries with Fedora 28 hardening and GCC 8 #6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnsmichi
added
bug
The actual fix is to handle nullptr references differently for an empty filter expression. The other changes include oob checks not necesarily involved. fixes #6533
dnsmichi
force-pushed
the
bugfix/gcc-8-f28-hardening-crash
branch
from
8dd931c
to
1f4f628
Compare
|
Tested this on macOS so it doesn't break anything else. |
|
This affects any request handler in the API, so I've tested other URL endpoints with and without the filter parameter too. Please do the same when reviewing this PR. |
|
How about a Unit test for FilterUtility? Should not be complicated since it is all static |
|
Started some test package builds, but that should be fine either way: |
|
I don't think that a unit test is that easy to implement with filter expressions, we should keep this out of this PR. I'm more interested in another pair of eyes looking at the fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual fix is to handle nullptr references differently
for an empty filter expression. The other changes include
oob checks not necesarily involved.
fixes #6533