-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup old code (HTTP, Cluster) #7196
Conversation
46ae6e0
to
61c8d7b
Compare
b4708f5
to
c77d6eb
Compare
The connection handling and code isn't really good, but not really actively maintained either. Besides that, the "telnet" method doesn't allow for TLS, this needs a general rewrite against their HTTP API. I've also added function documentation where applicable.
This commit changes the reconnect priority to high. Also add function docs.
LivestatusListener uses Unix/TcpSockets with object inheritance on the Socket class, I'd like to get rid of this as well. ExternalCommandListener uses a plain socket for the pipe, not sure if it is worth the hassle since this will be removed in 2.12 anyways. |
StreamReadContext with Netstring is something I'd like to get rid of as well, but likely in a separate attempt.
|
…ated They're used inside the Livestatus feature which needs rework.
Livestatus is a mess to rewrite, I'm leaving this for now in a WIP branch. |
Maybe it also is possible to rewrite the unix socket parts too.