[WIP] Feature/notification rework #7236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crunsher
added
area/notifications
|
Please also add function header docs which allows to better understand the purpose. |
|
Please update the current status, and provide a list of open TODOs. |
|
Currently the Component is in a state where a lot works and a lot dosen't. A few things are unclear yet but right now I'll be focusing on UnitTests. TODOs:
|
|
Update: Currently Problem, Recovery, Downtime and Flapping notifications work as far as I can tell. There is an issue with Acknowledgements and Custom Notifications are still TODO. |
|
This didn't go as planned, unfortunately I have to remove this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt in rewriting the NotificationComponent and aims to squash multiple issues we have with the current implementation.
The first step was adding a Scheduler for ReNotifications similar to that used in the CHeckerComponent.
In its current state this PR works, except for one or two Notifications Types, like the current one. The next Task is to find a solution for guaranteeing the execution of Notifications in a HA setup, moving more Notification related code from the lib/icinga to the NotificationComponent and writing Unit Tests.
refs #7161
Note: I rebased this on the master, squashing and reordering commits. It currently does not work.