Don't send event::Heartbeat to unauthenticated peers #7747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I've created #7698 as a draft a while ago which also aims to fix the problem. I took another approach i.e. to not spawn a coroutine to send heartbeat messages on unauthenticated peers. #7698 has the disadvantage that the disconnect/timeout logic is not executed. Whats your opinion @Al2Klimov? Feel free to close #7698, so we can focus on/test one patch. |
mcktr
added
the
area/distributed
|
@lippserd I'd opt for adding this to 2.12, avoiding a possible leak. |
|
@dnsmichi Yep, sounds good! |
|
@lippserd Thanks 👍 |
dnsmichi
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #7746
closes #7698