Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonRpcConnection#HandleAndWriteHeartbeats(): check !!#m_Endpoint #7926

Merged
merged 1 commit into from
Jun 3, 2020
Merged

JsonRpcConnection#HandleAndWriteHeartbeats(): check !!#m_Endpoint #7926

merged 1 commit into from
Jun 3, 2020

Conversation

Al2Klimov
Copy link
Member

No description provided.

@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Mar 18, 2020
@Al2Klimov Al2Klimov self-assigned this Mar 18, 2020
@Al2Klimov
Copy link
Member Author

@hardoverflow Please test whether v2.11.3 + this PR solves #7532 (comment) via packages from https://git.icinga.com/packaging/rpm-icinga2/-/jobs/45584 / "Job artifacts" / "Download".

@Al2Klimov Al2Klimov added the needs feedback We'll only proceed once we hear from you again label Mar 18, 2020
@Al2Klimov
Copy link
Member Author

Note: Commit is suitable for PR-ing into support/2.11.

@Al2Klimov
Copy link
Member Author

@lippserd @htriem Do you agree that this may be included in v2.12?

@hardoverflow
Copy link

@Al2Klimov Installed v2.11.3-2-g3af1129 on the ConfigMaster.

@Al2Klimov
Copy link
Member Author

Hello @hardoverflow!

Do you have already test results?

Best,
AK

@Al2Klimov Al2Klimov assigned hardoverflow and unassigned Al2Klimov Mar 30, 2020
@hardoverflow
Copy link

Last week, we deployed v2.11.3-2-g3af1129 on all masters and satellites in our env. We are still watching the following messages:

[2020-03-31 07:29:24 +0200] warning/JsonRpcConnection: Error while sending JSON-RPC message for identity 'client.fqdn'
Error: Connection reset by peer

        (0) icinga2: icinga::JsonRpcConnection::WriteOutgoingMessages(boost::asio::basic_yield_context<boost::asio::executor_binder<void (*)(), boost::asio::executor> >) (+0x274) [0xb65004]
        (1) /usr/lib64/icinga2/sbin/icinga2() [0xb653ea]
        (2) /usr/lib64/icinga2/sbin/icinga2() [0xb658c8]
        (3) libboost_context.so.1.69.0: make_fcontext (+0x2f) [0x7f76524a018f]

[2020-03-31 07:29:24 +0200] warning/JsonRpcConnection: API client disconnected for identity 'client.fqdn'

We could not observe that one of the masters crashed. However, we have observed the following.
2020-03-30 14_22_28-Icinga2 - Grafana
We have only seen this behavior once. We keep watching.

@Al2Klimov Al2Klimov marked this pull request as ready for review March 31, 2020 09:18
@Al2Klimov Al2Klimov removed the needs feedback We'll only proceed once we hear from you again label Mar 31, 2020
@Al2Klimov
Copy link
Member Author

@lippserd Would you like to have this in v2.12?

@Al2Klimov Al2Klimov added the needs feedback We'll only proceed once we hear from you again label Mar 31, 2020
@lippserd
Copy link
Member

@lippserd Would you like to have this in v2.12?

Yes indeed. Maybe even a 2.11.4.

@lippserd lippserd removed the needs feedback We'll only proceed once we hear from you again label Apr 30, 2020
@lippserd lippserd removed their assignment Apr 30, 2020
@Al2Klimov Al2Klimov modified the milestones: 2.13.0, 2.12.0 Apr 30, 2020
@Al2Klimov Al2Klimov requested a review from lippserd April 30, 2020 08:51
@Al2Klimov Al2Klimov requested a review from N-o-X June 3, 2020 13:41
@N-o-X N-o-X merged commit 84b052b into master Jun 3, 2020
@N-o-X N-o-X deleted the bugfix/jsonrpcconnection-handleandwriteheartbeats-m_endpoint-getname branch June 3, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-X N-o-X N-o-X approved these changes

@lippserd lippserd lippserd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Al2Klimov @hardoverflow @lippserd @N-o-X