Don't show parents children tab if icingadb.schema version < 6

Icinga · Dec 18, 2024 · fb557c7 · fb557c7
1 parent 6fb2e4b
commit fb557c7
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/application/controllers/HostController.php b/application/controllers/HostController.php
@@ -8,6 +8,7 @@
 use Icinga\Exception\NotFoundError;
 use Icinga\Module\Icingadb\Command\Object\GetObjectCommand;
 use Icinga\Module\Icingadb\Command\Transport\CommandTransport;
+use Icinga\Module\Icingadb\Common\Backend;
 use Icinga\Module\Icingadb\Common\CommandActions;
 use Icinga\Module\Icingadb\Common\HostLinks;
 use Icinga\Module\Icingadb\Common\Links;
@@ -432,13 +433,17 @@ protected function fetchNodes(bool $fetchParents = false): Query
 
     protected function createTabs(): Tabs
     {
-        $hasDependencyNode = DependencyNode::on($this->getDb())
-                ->columns('1')
-                ->filter(Filter::all(
-                    Filter::equal('host_id', $this->host->id),
-                    Filter::unlike('service_id', '*')
-                ))
-                ->first() !== null;
+        if (Backend::getDbSchemaVersion() < 6) {
+            $hasDependencyNode = false;
+        } else {
+            $hasDependencyNode = DependencyNode::on($this->getDb())
+                    ->columns('1')
+                    ->filter(Filter::all(
+                        Filter::equal('host_id', $this->host->id),
+                        Filter::unlike('service_id', '*')
+                    ))
+                    ->first() !== null;
+        }
 
         $tabs = $this->getTabs()
             ->add('index', [

diff --git a/application/controllers/ServiceController.php b/application/controllers/ServiceController.php
@@ -8,6 +8,7 @@
 use Icinga\Exception\NotFoundError;
 use Icinga\Module\Icingadb\Command\Object\GetObjectCommand;
 use Icinga\Module\Icingadb\Command\Transport\CommandTransport;
+use Icinga\Module\Icingadb\Common\Backend;
 use Icinga\Module\Icingadb\Common\CommandActions;
 use Icinga\Module\Icingadb\Common\Links;
 use Icinga\Module\Icingadb\Common\ServiceLinks;
@@ -400,13 +401,17 @@ protected function fetchNodes(bool $fetchParents = false): Query
 
     protected function createTabs(): Tabs
     {
-        $hasDependecyNode = DependencyNode::on($this->getDb())
-                ->columns('1')
-                ->filter(Filter::all(
-                    Filter::equal('service_id', $this->service->id),
-                    Filter::equal('host_id', $this->service->host_id)
-                ))
-                ->first() !== null;
+        if (Backend::getDbSchemaVersion() < 6) {
+            $hasDependencyNode = false;
+        } else {
+            $hasDependencyNode = DependencyNode::on($this->getDb())
+                    ->columns('1')
+                    ->filter(Filter::all(
+                        Filter::equal('service_id', $this->service->id),
+                        Filter::equal('host_id', $this->service->host_id)
+                    ))
+                    ->first() !== null;
+        }
 
         $tabs = $this->getTabs()
             ->add('index', [
@@ -418,7 +423,7 @@ protected function createTabs(): Tabs
                 'url'    => ServiceLinks::history($this->service, $this->service->host)
             ]);
 
-        if ($hasDependecyNode) {
+        if ($hasDependencyNode) {
             $tabs->add('parents', [
                 'label'  => t('Parents'),
                 'url'    => Url::fromPath(