Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken detail due to duplicate actions #999

Closed
nilmerg opened this issue Mar 22, 2024 · 0 comments · Fixed by #1000
Closed

Broken detail due to duplicate actions #999

nilmerg opened this issue Mar 22, 2024 · 0 comments · Fixed by #1000
Assignees
Labels
area/view Affects an entire view bug Something isn't working
Milestone

Comments

@nilmerg
Copy link
Member

nilmerg commented Mar 22, 2024

Describe the bug

property_exists(): Argument #1 ($object_or_class) must be of type object|string, null given

#0 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Common/Macros.php(51): property_exists(NULL, String)
#1 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Common/Macros.php(31): Icinga\Module\Icingadb\Web\Navigation\Action->resolveMacro(String, NULL)
#2 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Web/Navigation/Action.php(117): Icinga\Module\Icingadb\Web\Navigation\Action->expandMacros(String, NULL)
#3 /icingaweb2/library/Icinga/Web/Navigation/NavigationItem.php(759): Icinga\Module\Icingadb\Web\Navigation\Action->getUrl()
#4 /icingaweb2/library/Icinga/Web/Navigation/Navigation.php(380): Icinga\Web\Navigation\NavigationItem->conflictsWith(Object(Icinga\Module\Icingadb\Web\Navigation\IcingadbHostAction))
#5 /icingaweb2/library/Icinga/Web/Navigation/Navigation.php(423): Icinga\Web\Navigation\Navigation->merge(Object(Icinga\Web\Navigation\Navigation))
#6 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Widget/Detail/ObjectDetail.php(130): Icinga\Web\Navigation\Navigation->load(String)
#7 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Widget/Detail/HostDetail.php(46): Icinga\Module\Icingadb\Widget\Detail\ObjectDetail->createActions()
#8 /usr/local/src/ipl-html/src/HtmlDocument.php(344): Icinga\Module\Icingadb\Widget\Detail\HostDetail->assemble()
#9 /usr/local/src/ipl-html/src/HtmlDocument.php(566): ipl\Html\HtmlDocument->ensureAssembled()
#10 /usr/local/src/ipl-html/src/HtmlDocument.php(390): ipl\Html\HtmlDocument->render()
#11 /usr/local/src/ipl-html/src/BaseHtmlElement.php(297): ipl\Html\HtmlDocument->renderUnwrapped()
#12 /usr/local/src/ipl-html/src/BaseHtmlElement.php(365): ipl\Html\BaseHtmlElement->renderContent()
#13 /usr/local/src/ipl-html/src/HtmlDocument.php(568): ipl\Html\BaseHtmlElement->renderUnwrapped()
#14 /usr/local/src/ipl-html/src/HtmlDocument.php(390): ipl\Html\HtmlDocument->render()
#15 /usr/local/src/ipl-html/src/HtmlDocument.php(568): ipl\Html\HtmlDocument->renderUnwrapped()
#16 /usr/local/src/ipl-web/src/Compat/ViewRenderer.php(62): ipl\Html\HtmlDocument->render()
#17 /usr/share/icinga-php/vendor/vendor/shardj/zf1-future/library/Zend/Controller/Action/Helper/ViewRenderer.php(970): ipl\Web\Compat\ViewRenderer->render()
#18 /usr/share/icinga-php/vendor/vendor/shardj/zf1-future/library/Zend/Controller/Action/HelperBroker.php(277): Zend_Controller_Action_Helper_ViewRenderer->postDispatch()
#19 /usr/share/icingaweb2-modules/icingadb/library/Icingadb/Web/Controller.php(481): Zend_Controller_Action_HelperBroker->notifyPostDispatch()
#20 /icingaweb2/library/Icinga/Web/Controller/Dispatcher.php(76): Icinga\Module\Icingadb\Web\Controller->dispatch(String)
#21 /usr/share/icinga-php/vendor/vendor/shardj/zf1-future/library/Zend/Controller/Front.php(954): Icinga\Web\Controller\Dispatcher->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#22 /icingaweb2/library/Icinga/Application/Web.php(294): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
#23 /icingaweb2/library/Icinga/Application/webrouter.php(105): Icinga\Application\Web->dispatch()
#24 /icingaweb2/public/index.php(4): require_once(String)
#25 {main}

To Reproduce

  1. Create a host action with name "test" and a macro in the url
  2. Share it with user Bob
  3. Login as Bob
  4. Create a host action name "test" and a macro in the url
  5. Visit any host

Expected behavior

No stacktrace.

@nilmerg nilmerg added bug Something isn't working area/view Affects an entire view labels Mar 22, 2024
@nilmerg nilmerg added this to the 1.1.2 milestone Mar 22, 2024
@nilmerg nilmerg self-assigned this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/view Affects an entire view bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant