Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redundancy group detail view #1079

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Oct 16, 2024

resolves #1056

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Oct 16, 2024
@sukhwinder33445 sukhwinder33445 marked this pull request as draft October 16, 2024 14:07
@sukhwinder33445 sukhwinder33445 force-pushed the add-redundancy-group-detail-view branch 2 times, most recently from bb57bd1 to f0587fd Compare October 17, 2024 12:19
@raviks789 raviks789 force-pushed the root-problem-list branch 8 times, most recently from eefd449 to e82398e Compare October 25, 2024 10:54
@raviks789 raviks789 force-pushed the root-problem-list branch 8 times, most recently from 4be5a02 to bfb4c51 Compare October 31, 2024 08:47
Base automatically changed from root-problem-list to dependencies October 31, 2024 11:07
@sukhwinder33445 sukhwinder33445 force-pushed the add-redundancy-group-detail-view branch 9 times, most recently from 30610c2 to cc17f79 Compare November 12, 2024 19:12
@sukhwinder33445 sukhwinder33445 force-pushed the add-redundancy-group-detail-view branch 3 times, most recently from 9bee89a to f6f6316 Compare November 14, 2024 15:34
RedundancyGroupSummary: Add columns for `(un)acknowledged` count
@sukhwinder33445 sukhwinder33445 force-pushed the add-redundancy-group-detail-view branch 4 times, most recently from 3675d71 to 7332d2c Compare November 15, 2024 13:48
@nilmerg nilmerg marked this pull request as ready for review November 18, 2024 13:36
library/Icingadb/Data/DependencyNodes.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/Detail/MultiselectQuickActions.php Outdated Show resolved Hide resolved
application/controllers/RedundancygroupController.php Outdated Show resolved Hide resolved
application/controllers/RedundancygroupController.php Outdated Show resolved Hide resolved
application/controllers/RedundancygroupController.php Outdated Show resolved Hide resolved
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review done, testing now

@sukhwinder33445 sukhwinder33445 force-pushed the add-redundancy-group-detail-view branch from bc79ebc to dc09970 Compare November 19, 2024 15:40
@sukhwinder33445 sukhwinder33445 force-pushed the add-redundancy-group-detail-view branch 2 times, most recently from 46f7097 to e459865 Compare November 19, 2024 16:04
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 - Use Translation trait's translate() method
 - Add sort columns to DependencyNode
RedundancygroupController: Add class property for group summary

RedundancygroupController: Apply missing restrictions in `fetchNodes()` method

rg: Use $this->httpNotFound instead

rg: remove superfluous searchbar param
…vices

- Add missing relation `state.last_comment` for detailed view mode
@sukhwinder33445 sukhwinder33445 force-pushed the add-redundancy-group-detail-view branch from b6ab15c to 3567a40 Compare November 19, 2024 16:45
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM²!

@nilmerg nilmerg merged commit ae9002d into dependencies Nov 19, 2024
22 checks passed
@nilmerg nilmerg deleted the add-redundancy-group-detail-view branch November 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants