Object permissions #158
Merged
Object permissions #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
force-pushed
the
native-object-restriction
branch
6 times, most recently
from
10ec2e3 to
f9aa58f
Compare
nilmerg
force-pushed
the
native-object-restriction
branch
from
f9aa58f to
45aec8c
Compare
nilmerg
force-pushed
the
native-object-restriction
branch
6 times, most recently
from
30e115b to
789b9a0
Compare
nilmerg
force-pushed
the
native-object-restriction
branch
from
789b9a0 to
99d5380
Compare
`grantsOnType()` will now perform the permission check it is asked for on every object that matches the filter. It will then cache all individual results so that any subsequent call to `grantsOn()` will hit the cache instead of triggering another query.
The cache is not needed in this case. Populating the cache is a rather expensive task.
nilmerg
force-pushed
the
native-object-restriction
branch
from
99d5380 to
2130926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permissions and restrictions from the very same role are now tied together. That means the permissions of a role won't apply to objects that are available due to another role.
refs Icinga/icingaweb2#2455