Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regulate object links based on backend used #128

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Regulate object links based on backend used #128

merged 4 commits into from
Apr 30, 2024

Conversation

raviks789
Copy link
Contributor

@raviks789 raviks789 commented Feb 9, 2024 •
edited
Loading

fix #125

@cla-bot cla-bot bot added the cla/signed label Feb 9, 2024
@raviks789 raviks789 force-pushed the fix/object-links branch 3 times, most recently from c35cfb9 to 9563cef Compare February 12, 2024 14:48
@raviks789 raviks789 self-assigned this Feb 12, 2024
@raviks789 raviks789 changed the title WIP Regulate object links based on backend used Feb 13, 2024
@raviks789 raviks789 marked this pull request as ready for review February 13, 2024 09:08
@raviks789 raviks789 requested a review from nilmerg February 13, 2024 09:08
@raviks789 raviks789 force-pushed the fix/object-links branch 5 times, most recently from 69d6ea1 to b939d7f Compare February 13, 2024 14:01
@nilmerg nilmerg added this to the 1.3.4 milestone Feb 21, 2024
nilmerg
nilmerg requested changes Feb 21, 2024
View reviewed changes
application/clicommands/SendCommand.php Outdated Show resolved Hide resolved
library/Jira/Web/Form/NewIssueForm.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
@nilmerg nilmerg added the bug Something isn't working label Feb 21, 2024
@raviks789 raviks789 requested a review from nilmerg February 21, 2024 13:07
@raviks789 raviks789 force-pushed the fix/object-links branch 3 times, most recently from 9c6e94d to 92666b6 Compare February 21, 2024 15:13
nilmerg
nilmerg requested changes Apr 12, 2024
View reviewed changes
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
@nilmerg nilmerg requested a review from sukhwinder33445 April 12, 2024 07:20
@nilmerg
Copy link
Member

nilmerg commented Apr 12, 2024

@sukhwinder33445 Please perform a test.

@raviks789 raviks789 force-pushed the fix/object-links branch 2 times, most recently from 7733ef4 to aa14ea6 Compare April 17, 2024 15:42
sukhwinder33445
sukhwinder33445 requested changes Apr 18, 2024
View reviewed changes
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/Table/IssueDetails.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
sukhwinder33445
sukhwinder33445 previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

@raviks789 raviks789 requested a review from nilmerg April 18, 2024 08:18
nilmerg
nilmerg requested changes Apr 25, 2024
View reviewed changes
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the fix/object-links branch 2 times, most recently from 0671c7c to 4e49694 Compare April 25, 2024 09:31
sukhwinder33445
sukhwinder33445 requested changes Apr 25, 2024
View reviewed changes
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
sukhwinder33445
sukhwinder33445 reviewed Apr 25, 2024
View reviewed changes
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the fix/object-links branch 2 times, most recently from bf7f819 to 43d2327 Compare April 25, 2024 13:49
sukhwinder33445
sukhwinder33445 reviewed Apr 26, 2024
View reviewed changes
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
library/Jira/Web/RenderingHelper.php Outdated Show resolved Hide resolved
@raviks789 raviks789 merged commit d324d29 into main Apr 30, 2024
15 checks passed
@raviks789 raviks789 deleted the fix/object-links branch April 30, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukhwinder33445 sukhwinder33445 sukhwinder33445 approved these changes

@nilmerg nilmerg nilmerg approved these changes

Assignees

@raviks789 raviks789

Labels
bug Something isn't working cla/signed
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.

Links in tickets still use /monitoring instead of /icingadb
3 participants
@raviks789 @nilmerg @sukhwinder33445