Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide migration hook & migrate jobs config to database #195

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Provide migration hook & migrate jobs config to database #195

merged 5 commits into from
Sep 19, 2023

Conversation

yhabteab
Copy link
Member

@cla-bot cla-bot bot added the cla/signed label Jul 19, 2023
@yhabteab yhabteab added the enhancement New feature or improvement label Jul 19, 2023
@yhabteab yhabteab added this to the 1.2.2 milestone Jul 19, 2023
@yhabteab yhabteab self-assigned this Jul 19, 2023
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 2 times, most recently from e29b76c to 570b9f4 Compare July 19, 2023 14:45
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 7 times, most recently from 71d5488 to 9160ee1 Compare July 26, 2023 14:37
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 3 times, most recently from eb25f36 to 2beebb2 Compare July 31, 2023 13:16
@yhabteab yhabteab force-pushed the migration-hook branch 3 times, most recently from a09f25c to 99d3a25 Compare August 7, 2023 11:31
@yhabteab yhabteab mentioned this pull request Aug 7, 2023
Merged
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 4 times, most recently from 0632efb to f19c7e9 Compare August 11, 2023 11:00
@yhabteab yhabteab force-pushed the migration-hook branch 2 times, most recently from d811b54 to b9e60e5 Compare August 30, 2023 11:45
@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch from f19c7e9 to 6f1fe2a Compare August 30, 2023 11:46
nilmerg
nilmerg reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation doesn't really emphasize now that the migrate command needs to run in any case. Please adjust that somewhat.

Otherwise looks okay, though my final approve only follows once the checks ran. (after the referenced pr has been merged)

@yhabteab yhabteab force-pushed the separate-jobs-and-schedule-config branch 4 times, most recently from d8d38f0 to c45935d Compare September 14, 2023 07:08
Base automatically changed from separate-jobs-and-schedule-config to main September 14, 2023 07:09
@yhabteab yhabteab force-pushed the migration-hook branch 4 times, most recently from 71a45d5 to e653018 Compare September 15, 2023 12:28
nilmerg
nilmerg requested changes Sep 15, 2023
View reviewed changes
doc/80-Upgrading.md Outdated Show resolved Hide resolved
doc/80-Upgrading.md Show resolved Hide resolved
@yhabteab yhabteab force-pushed the migration-hook branch 2 times, most recently from bbfc1ad to 49980d9 Compare September 15, 2023 13:40
@yhabteab yhabteab requested a review from nilmerg September 15, 2023 13:41
nilmerg
nilmerg previously approved these changes Sep 15, 2023
View reviewed changes
nilmerg
nilmerg previously approved these changes Sep 18, 2023
View reviewed changes
@yhabteab
Copy link
Member Author

Just rebased!

@yhabteab yhabteab requested a review from nilmerg September 19, 2023 13:35
@nilmerg nilmerg merged commit a018015 into main Sep 19, 2023
12 checks passed
@nilmerg nilmerg deleted the migration-hook branch September 19, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

@sukhwinder33445 sukhwinder33445 sukhwinder33445 left review comments

Assignees

@yhabteab yhabteab

Labels
cla/signed enhancement New feature or improvement
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yhabteab @nilmerg @sukhwinder33445