Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete log messages in case of a faulty custom variable hook implementation #5258

Closed
nilmerg opened this issue Sep 16, 2024 · 0 comments · Fixed by #5283
Closed

Incomplete log messages in case of a faulty custom variable hook implementation #5258

nilmerg opened this issue Sep 16, 2024 · 0 comments · Fixed by #5283
Assignees
@nilmerg
Labels
area/framework Affects third party integration/development bug Something isn't working
Milestone
2.12.2

Comments

@nilmerg
Copy link
Member

nilmerg commented Sep 16, 2024

Describe the bug

There is no error message nor a stacktrace included in the log.

To Reproduce

Have a faulty implementation of Icinga\Module\Monitoring\Hook\CustomVarRendererHook

Expected behavior

An error message and a short stacktrace.
@nilmerg nilmerg added bug Something isn't working area/framework Affects third party integration/development labels Sep 16, 2024
@nilmerg nilmerg added this to the 2.12.2 milestone Sep 16, 2024
nilmerg added a commit that referenced this issue Nov 4, 2024
@nilmerg
CustomVarRendererHook: Log an exception's message and location
fdbd903 
fixes #5258
@nilmerg nilmerg mentioned this issue Nov 4, 2024
Merged
@nilmerg nilmerg closed this as completed in 8f1eaf0 Nov 4, 2024
@nilmerg nilmerg self-assigned this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilmerg nilmerg

Labels
area/framework Affects third party integration/development bug Something isn't working
Projects
None yet
Milestone
2.12.2
Development

Successfully merging a pull request may close this issue.

CustomVarRendererHook: Log an exception's message and location Icinga/icingaweb2
1 participant
@nilmerg