Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonitoredObject notes: don't pass null to trim() #5228

Closed
wants to merge 1 commit into from

Conversation

Al2Klimov
Copy link
Member

as this is deprecated and generates warnings in the detail view if the notes are null. In this case fall back to "" which is already handled by the following code.

fixes #5221

as this is deprecated and generates warnings in the detail view if the notes are null. In this case fall back to "" which is already handled by the following code.
@Al2Klimov Al2Klimov added bug Something isn't working area/monitoring Affects the monitoring module area/ui Affects the user interface labels Jun 21, 2024
@cla-bot cla-bot bot added the cla/signed label Jun 21, 2024
@nilmerg
Copy link
Member

nilmerg commented Aug 14, 2024

See issue for the explanation.

@nilmerg nilmerg closed this Aug 14, 2024
@nilmerg nilmerg deleted the Al2Klimov-patch-4 branch August 14, 2024 14:24
@nilmerg nilmerg removed bug Something isn't working area/monitoring Affects the monitoring module area/ui Affects the user interface labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP deprecation errors
2 participants