Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About Page: Suppress the MigrationManager exception #5239

Merged
merged 1 commit into from
Nov 4, 2024
Merged

About Page: Suppress the MigrationManager exception #5239

merged 1 commit into from
Nov 4, 2024

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Jul 31, 2024 •
edited
Loading

fixes #5236

@sukhwinder33445 sukhwinder33445 added bug Something isn't working area/ui Affects the user interface labels Jul 31, 2024
@sukhwinder33445 sukhwinder33445 self-assigned this Jul 31, 2024
@cla-bot cla-bot bot added the cla/signed label Jul 31, 2024
@sukhwinder33445 sukhwinder33445 marked this pull request as draft July 31, 2024 12:24
@sukhwinder33445 sukhwinder33445 force-pushed the dont-break-ui-when-migration-hook-fails branch from d50f8c3 to 45129d6 Compare July 31, 2024 12:50
@nilmerg
Copy link
Member

nilmerg commented Aug 13, 2024

Previously the migration overview crashed with the same error. While this is bad in the about section, it's okay in the migration overview. So please catch any error in the about section only, so that they're still visible in the migration overview.

@nilmerg nilmerg added this to the 2.12.2 milestone Aug 13, 2024
@sukhwinder33445 sukhwinder33445 changed the title MigrationManager: Do not break the UI if the hook cannot be loaded MigrationManager: Do not break the About page if the hook cannot be loaded Sep 17, 2024
@sukhwinder33445 sukhwinder33445 force-pushed the dont-break-ui-when-migration-hook-fails branch 2 times, most recently from 145d15e to 67bf0de Compare September 17, 2024 08:59
@sukhwinder33445 sukhwinder33445 changed the title MigrationManager: Do not break the About page if the hook cannot be loaded About Page: Suppress the MigrationManager exception Sep 17, 2024
@sukhwinder33445 sukhwinder33445 force-pushed the dont-break-ui-when-migration-hook-fails branch from 67bf0de to 61a90e2 Compare September 17, 2024 09:20
@nilmerg nilmerg marked this pull request as ready for review November 4, 2024 08:18
@nilmerg nilmerg merged commit 9f14c32 into main Nov 4, 2024
22 checks passed
@nilmerg nilmerg deleted the dont-break-ui-when-migration-hook-fails branch November 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@sukhwinder33445 sukhwinder33445

Labels
area/ui Affects the user interface bug Something isn't working cla/signed
Projects
None yet
Milestone
2.12.2
Development

Successfully merging this pull request may close these issues.

Enabled but not configured module breaks About page in Icinga Web
2 participants
@sukhwinder33445 @nilmerg