Str: Fix passing null to explode() PHP 8.1 warnings
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
reviewed
Nov 7, 2022
|
The entire class is affected by this. Please also adjust the remaining methods. |
yhabteab
force-pushed
the
fix-php81-warnings
branch
from
b6769eb to
b424957
Compare
nilmerg
requested changes
Nov 7, 2022
yhabteab
force-pushed
the
fix-php81-warnings
branch
2 times, most recently
from
0c4bdc6 to
2508ca1
Compare
|
Why don't we add |
yhabteab
force-pushed
the
fix-php81-warnings
branch
2 times, most recently
from
9f8238f to
cbd3485
Compare
Well, since this is a utility class (not specifically meant to be sub-classed), this would be indeed a possibility! |
nilmerg
requested changes
Nov 8, 2022
yhabteab
force-pushed
the
fix-php81-warnings
branch
from
cbd3485 to
feed14b
Compare
nilmerg
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.