SearchControls: Don't use UrlParams instance for setEditorUrl() #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
reviewed
Nov 21, 2024
- Otherwise for example calling `$searchbar->getEditorUrl()->setParam('foo')` to manupulate params in *Any*Controller
will affect the params of $redurectUrl
sukhwinder33445
force-pushed
the
fix-search-controls
branch
from
22bfe13 to
ea2a39b
Compare
nilmerg
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Note that I do not approve this to justify what you did here.
The reason is rather, that the redirect URL can be provided by the caller. In this case the caller is responsible for the parameters, in which case it's bad practice to pass them on to another URL or even adjust them without cloning.
|
@cla-bot check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.