Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchControls: Do not encode params multiple times #237

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

sukhwinder33445
Copy link
Contributor

No description provided.

@sukhwinder33445 sukhwinder33445 self-assigned this Nov 25, 2024
@sukhwinder33445 sukhwinder33445 marked this pull request as draft November 25, 2024 13:44
@nilmerg
Copy link
Member

nilmerg commented Nov 26, 2024

@cla-bot check

1 similar comment
@sukhwinder33445
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla/signed label Dec 5, 2024
…irectUrl

- The (set/add)Params() method always encodes the params. This way we can avoid encoding the parameters twice.
@sukhwinder33445 sukhwinder33445 force-pushed the fix/decode-params-to-add-properly branch from 8a37b1c to dc26025 Compare December 9, 2024 15:34
@sukhwinder33445 sukhwinder33445 marked this pull request as ready for review December 9, 2024 15:34
@nilmerg nilmerg merged commit 003c51b into main Dec 9, 2024
22 checks passed
@nilmerg nilmerg deleted the fix/decode-params-to-add-properly branch December 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants