Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overload primitives #173

Merged
merged 1 commit into from
Nov 16, 2024
Merged

fix: don't overload primitives #173

merged 1 commit into from
Nov 16, 2024

Conversation

peppelinux
Copy link
Member

this PR removes the overload of the primitive str

generally, it would be preferable avoid also variables with single char names, like b or any other that might overload pdb commands

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.33%. Comparing base (69fed0a) to head (f557be4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   76.24%   76.33%   +0.08%     
==========================================
  Files          44       44              
  Lines        4484     4484              
  Branches      984      839     -145     
==========================================
+ Hits         3419     3423       +4     
  Misses        777      777              
+ Partials      288      284       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jschlyter
Copy link
Contributor

IIRC there are ruff rules that can be enabled to catch things like this.

@jschlyter jschlyter merged commit 776aef5 into main Nov 16, 2024
14 checks passed
@jschlyter jschlyter deleted the str-patch branch November 16, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants