Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting the view after signal close #603

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix deleting the view after signal close #603

merged 1 commit into from
Sep 25, 2023

Conversation

pgorszkowski-igalia
Copy link
Contributor

WebKitWebView inherits from GObject so it is not needed to do g_object_ref_sink on it. It fixes the problem with deleting the view after receiving "close" signal.

@pgorszkowski-igalia
Fix deleting the view after signal close
5df3012 
WebKitWebView inherits from GObject so it is not needed to do
g_object_ref_sink on it. It fixes the problem with deleting the
view after receiving "close" signal.
@pgorszkowski-igalia pgorszkowski-igalia mentioned this pull request Sep 25, 2023
Closed
TingPing
TingPing approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@TingPing TingPing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

I assume this mistake was because in WebKitGTK it is a GtkWidget which is GInitiallyUnowned. Indeed in WPE it is a normal GObject.

@pgorszkowski-igalia
Copy link
Contributor Author

Makes sense.

I assume this mistake was because in WebKitGTK it is a GtkWidget which is GInitiallyUnowned. Indeed in WPE it is a normal GObject.

So maybe I should use if (G_IS_INITIALLY_UNOWNED (priv->web_view)) ?

@aperezdc
Copy link
Member

Makes sense.
I assume this mistake was because in WebKitGTK it is a GtkWidget which is GInitiallyUnowned. Indeed in WPE it is a normal GObject.

So maybe I should use if (G_IS_INITIALLY_UNOWNED (priv->web_view)) ?

No need. Cog can only use WPE WebKit these days, we no longer support linking against WebKitGTK.

@aperezdc aperezdc merged commit 1d27133 into Igalia:master Sep 25, 2023
5 checks passed
@aperezdc aperezdc added bug Something isn't working merge:cog-0.18 labels Sep 25, 2023
@aperezdc
Copy link
Member

Cherry-picked into the cog-0.18 branch as commit a888726, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TingPing TingPing TingPing approved these changes

@aperezdc aperezdc aperezdc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working merge:cog-0.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgorszkowski-igalia @aperezdc @TingPing