Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Warn on both get_view_type and init_web_view defined #627

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

aperezdc
Copy link
Member

Emit a warning when trying to call cog_platform_init_web_view() in case the platform in use defines both .get_view_type and .init_web_view, because the latter shall not be defined when .get_view_type is in use.

Emit a warning when trying to call cog_platform_init_web_view() in case
the platform in use defines both .get_view_type and .init_web_view,
because the latter shall not be defined when .get_view_type is in use.
@aperezdc aperezdc added the enhancement New feature or request label Oct 26, 2023
@aperezdc aperezdc requested a review from psaavedra October 26, 2023 08:12
@aperezdc aperezdc self-assigned this Oct 26, 2023
Copy link
Member

@psaavedra psaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aperezdc aperezdc merged commit e3efab0 into master Oct 26, 2023
5 checks passed
@aperezdc aperezdc deleted the aperezdc/view-warn-init branch October 26, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants