Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First models implemented, running version #96

Merged
merged 30 commits into from
Dec 11, 2024
Merged

First models implemented, running version #96

merged 30 commits into from
Dec 11, 2024

Conversation

JortGroen
Copy link
Collaborator

Models running:

  • CSV_reader_v3
  • Battery_v3
  • Load_v3
  • Collector (placeholder)

Hotfixes in model.py and engine.py to have things running

timing is functional but needs extra testing

default values get initialised and overwritten when existing in the yaml

JortGroen and others added 30 commits December 5, 2024 08:53
@JortGroen
passing the right things to world.start
6cadc91
@JortGroen
makes the models run every step
1ac2a24
@JortGroen
temporary usage of old collector
fa22721
@JortGroen
more distinguished prints from the adder model
eb14a0e
@JortGroen
next_row is more like an output than it is a parameter
0b4763b
@JortGroen
example csv to test the battery
bd040b2
@JortGroen
make the collector update every step
993d2fd
@JortGroen
Make collector update every step
ad5d4c8
@Eutardigrada
Changed csv path to battery.yaml, results in csv
1c954ac
@Eutardigrada
Collector resolution hotfix, Added TODOs
3054d7d
@JortGroen
converted load model to v3 structure. the battery.yaml now includes load
3dc8cfe
@JortGroen
This (manual setting parameters) is an unwanted way of setting defaul…
c52e50e 
…ts. Commenting out for now
@JortGroen
added TODO considering time
1a6ec67
@JortGroen
TODO for future generalisation
2d2c6a2
@JortGroen
Merge branch 'model-dev' of https://github.com/Illuminator-team/Illum…
471f5f6 
…inator into model-dev
@JortGroen
make battery.yaml work
54129d0
@Eutardigrada
Changed how eid is accessed in battery model
3711a17
@JortGroen
Add a model's time_step_size to be defined through the model
8bd7841
@JortGroen
model defaults now working
d8aebae
@JortGroen
Adder model now has defaults
7909935
@JortGroen
TODO related to timings
79aed23
@JortGroen
adding time_step_size to be defined through the yaml
fd8bc77
@JortGroen
Merge branch 'model-dev' of https://github.com/Illuminator-team/Illum…
25dbc3d 
…inator into model-dev
@JortGroen
default values for CSV reader
fab2680
@JortGroen
default values for battery
2c607ad
@JortGroen
default values for Load model
9abafe1
@JortGroen
converted PV model to version 3 structure
4e48c53
@JortGroen
load model doesn't need an init function
1a41ee1
@JortGroen
time resolutions shouldn't be defined per model, we have time_step_size
aee2d3e
@JortGroen
all step definitions should have max_advance as argument
856dd45
@Eutardigrada Eutardigrada merged commit 48d215d into dev Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eutardigrada Eutardigrada Awaiting requested review from Eutardigrada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JortGroen @Eutardigrada