Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add em and rem to jive::Length #114

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Add em and rem to jive::Length #114

merged 1 commit into from
Sep 30, 2023

Conversation

ImJimmi
Copy link
Owner

@ImJimmi ImJimmi commented Sep 30, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a8d5147) 92.58% compared to head (b908abe) 92.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   92.58%   92.60%   +0.02%     
==========================================
  Files         100      101       +1     
  Lines        9752     9834      +82     
==========================================
+ Hits         9029     9107      +78     
- Misses        723      727       +4     
Files Coverage Δ
jive_core/geometry/jive_Length.h 100.00% <ø> (ø)
jive_core/geometry/jive_Length.cpp 96.24% <95.34%> (-1.91%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ImJimmi ImJimmi merged commit e0d62d2 into main Sep 30, 2023
5 checks passed
@ImJimmi ImJimmi deleted the relative-lengths branch September 30, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant