Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor proposals #137

Merged
merged 122 commits into from
Jun 12, 2023
Merged

Refactor proposals #137

merged 122 commits into from
Jun 12, 2023

Conversation

cuteolaf
Copy link
Contributor

@cuteolaf cuteolaf commented May 31, 2023 •
edited by f-gate
Loading

Solves:
#97
#102
#122
#85

  • Project Migration for modified storage
  • Project Migration for removed storage types
  • Integrity tests for the migrations
  • Include pallet-crowdfunding into runtime(?)
  • Test coverage
  • List api changes for dapp
  • Storage Deposits
  • Test for when storage deposits are taken Briefs + Grants + Proposals - deposit taken is 0, tests are covered in pallet_deposits
  • Migrations for Grant: milestone percent + deposit id
  • Migrations for BriefData: milestone percent + deposit_id

hbulgarini and others added 30 commits May 13, 2023 02:03
@hbulgarini
Milestone Review WIP
47d45bb
@hbulgarini
SBP review
31158e5
@f-gate
Merge pull request #115 from hbulgarini/main
29a39f3 
SBP Milestone Review 3
@f-gate
start round fefactor, remove tests
9428181
@f-gate
clean up error and events
3874b7f
@f-gate
fixes
fc09b7f
@f-gate
Merge branch 'main' of github.com:ImbueNetwork/imbue into refactor-pr…
41415fb 
…oposals
@f-gate
it builds
8ed5bda
@f-gate
clean rounds in on itit
d82f3b2
@f-gate
start testing
b548343
@f-gate
some tests, test_utils
6e8922b
@f-gate
submit milestone tests
85273af
@f-gate
vote on milestone tests
9cc7ee1
@f-gate
simpliy new_milestone_vote greatly
aa86f2f
@f-gate
remove votes at voting round expiry
c70ba8f
@f-gate
use new round cleaning logic in the codebase
74257bf
@f-gate
fix auto approve, tests
575d64a
@f-gate
allow resubmission of a milestone
028694e
@f-gate
tests for withdraws
6129dfd
@f-gate
fix up
31afd18
@f-gate
call vote of no confidence tests
0e48a73
@f-gate
add vote tests
e5089b4
@cuteolaf
Merge branch 'main' into sbp3-review
1608183
@cuteolaf
audit fix
7eec2e6
@cuteolaf
replace insert with mutate_exists
9fa1be5
@f-gate
migrations
8fb4129
@cuteolaf
revert indentation changes
5302b45
@cuteolaf
use sp_arithmetic
15f85dc
@cuteolaf
fix tests
df0352f
@cuteolaf
another use case of percent
9bcb9eb
This was linked to issues Jun 8, 2023
Update weights to use v2 #127
Closed
Renerate weights and use benchmarks #103
Closed
@samelamin samelamin marked this pull request as ready for review June 12, 2023 14:04
@samelamin
Copy link
Contributor

Lets add the crowdfunding pallet in a different pr because this one was deployed to ksm

@samelamin samelamin merged commit d30bc47 into main Jun 12, 2023
@samelamin samelamin deleted the refactor-proposals branch June 12, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samelamin samelamin samelamin approved these changes

@f-gate f-gate Awaiting requested review from f-gate

@aalavanthan18 aalavanthan18 Awaiting requested review from aalavanthan18

Assignees

@f-gate f-gate

@cuteolaf cuteolaf

Labels
Priority | High refactor Refactoring is required
Projects
None yet
Milestone
No milestone
4 participants
@cuteolaf @samelamin @f-gate @hbulgarini