Skip to content

Commit

Permalink
Fix Guacamole shared drive always enabled (microsoft#4046)
Browse files Browse the repository at this point in the history
* Fix Guacamole shared drive always enabled

Related to microsoft#3885

Update Guacamole shared drive configuration to respect the 'drive' option setting.

* Change the default value of `guac_enable_drive` to `false` in `templates/workspace_services/guacamole/porter.yaml`.
* Change the default value of `guac_enable_drive` to `false` in `templates/workspace_services/guacamole/template_schema.json`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3885?shareId=XXXX-XXXX-XXXX-XXXX).

* Update change log

* Update CHANGELOG.md

---------

Co-authored-by: Tim Allen <tim.allen@cloudkubed.com>
  • Loading branch information
marrobi and tim-allen-ck committed Aug 5, 2024
1 parent e14f440 commit b1243d8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ ENHANCEMENTS:
BUG FIXES:
* Fix numbering issue within `bug_report.md` template ([#4028](https://github.com/microsoft/AzureTRE/pull/4028))
* Disable public network access to the API App Service ([#3986](https://github.com/microsoft/AzureTRE/issues/3986))
* Fix Guacamole shared drive always enabled ([#3885](https://github.com/microsoft/AzureTRE/issues/3885))
* Add Dependabot Security updates for July
* Update Docs to format emojis properly ([#4027](https://github.com/microsoft/AzureTRE/issues/4027))
* Update API and Resource Processor opentelemetry versions ([#4052](https://github.com/microsoft/AzureTRE/issues/4052))
Expand Down
2 changes: 1 addition & 1 deletion templates/workspace_services/guacamole/porter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ parameters:
description: "Guacamole disable paste configuration"
- name: guac_enable_drive
type: boolean
default: true
default: false
env: GUAC_ENABLE_DRIVE
description: "Guacamole enable drive configuration"
- name: guac_drive_name
Expand Down
3 changes: 2 additions & 1 deletion templates/workspace_services/guacamole/template_schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@
"type": "boolean",
"title": "Enable Drive",
"description": "Enable mounted drive",
"updateable": true
"updateable": true,
"default": false
},
"guac_disable_download": {
"$id": "#/properties/guac_disable_download",
Expand Down

0 comments on commit b1243d8

Please sign in to comment.