-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to CI #110
Merged
Merged
Update to CI #110
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0f4c595
Updated workflow to test with python 3.11
jacobcook1995 41a1fa0
Updated deprecated actions
jacobcook1995 cad743b
Adding 3.11 was premature
jacobcook1995 e19ba59
Didn't seem to like v3
jacobcook1995 edeadc8
Hopefully being more specific with the version numbers helps
jacobcook1995 ae2be54
Rebuilt poetry lock to address merge problem
jacobcook1995 b66d218
Adding python 3.11 to see if there are runners for it yet
jacobcook1995 73fb1d1
Updated lock which should hopefully fix the dependancy clash
jacobcook1995 fe8a971
Test if updating the poetry version fixes the problem
jacobcook1995 b7ba18a
Updated poetry version
jacobcook1995 13e68de
Update action versions
jacobcook1995 4a59661
Have to specify precise checkout version apparently
jacobcook1995 3c9f5b4
Now specifying pre-commit/action version properly
jacobcook1995 5bdc0db
Added full version for actions-poetry
jacobcook1995 73f3c5e
Added groupings to poetry dependancies
jacobcook1995 5aea8c2
Reordered dependancy groupings based on David's suggestion
jacobcook1995 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python 3.11? That's brave!
Not a bad idea to try with the latest version of Python, but just don't be surprised if things don't work yet. It'll probably be months (years?) before all the common packages actually work with v3.11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh right, I think this is maybe a coming from Julia thing where the updates have often fixed major problems with the language, so people switch pretty quickly. I guess we can keep 3.11 in the CI for now and then remove it if/when it becomes a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I briefly added
3.11-dev
(7c9ef44) and the wheels came off alarmingly quickly.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, up to you. It's not a bad thing, but it just might mean you have to remove it from the CI again later -- not a big deal.