Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CI #110

Merged
merged 16 commits into from
Nov 9, 2022
Merged

Update to CI #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0f4c595
Updated workflow to test with python 3.11
jacobcook1995 Oct 25, 2022
41a1fa0
Updated deprecated actions
jacobcook1995 Oct 25, 2022
cad743b
Adding 3.11 was premature
jacobcook1995 Oct 25, 2022
e19ba59
Didn't seem to like v3
jacobcook1995 Oct 25, 2022
edeadc8
Hopefully being more specific with the version numbers helps
jacobcook1995 Oct 25, 2022
ae2be54
Rebuilt poetry lock to address merge problem
jacobcook1995 Nov 4, 2022
b66d218
Adding python 3.11 to see if there are runners for it yet
jacobcook1995 Nov 4, 2022
73fb1d1
Updated lock which should hopefully fix the dependancy clash
jacobcook1995 Nov 4, 2022
fe8a971
Test if updating the poetry version fixes the problem
jacobcook1995 Nov 4, 2022
b7ba18a
Updated poetry version
jacobcook1995 Nov 4, 2022
13e68de
Update action versions
jacobcook1995 Nov 4, 2022
4a59661
Have to specify precise checkout version apparently
jacobcook1995 Nov 4, 2022
3c9f5b4
Now specifying pre-commit/action version properly
jacobcook1995 Nov 4, 2022
5bdc0db
Added full version for actions-poetry
jacobcook1995 Nov 4, 2022
73f3c5e
Added groupings to poetry dependancies
jacobcook1995 Nov 8, 2022
5aea8c2
Reordered dependancy groupings based on David's suggestion
jacobcook1995 Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ jobs:
qa:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: actions/setup-python@v4
with:
python-version: "3.9"
- uses: pre-commit/action@v2.0.2
- uses: pre-commit/action@v3.0.0

test:
needs: qa
Expand All @@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
os: [ ubuntu-latest, macos-latest, windows-latest ]
python-version: [ "3.9" , "3.10.6" ]
python-version: [ "3.9" , "3.10", "3.11" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.11? That's brave!

Not a bad idea to try with the latest version of Python, but just don't be surprised if things don't work yet. It'll probably be months (years?) before all the common packages actually work with v3.11.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh right, I think this is maybe a coming from Julia thing where the updates have often fixed major problems with the language, so people switch pretty quickly. I guess we can keep 3.11 in the CI for now and then remove it if/when it becomes a problem?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly added 3.11-dev (7c9ef44) and the wheels came off alarmingly quickly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, up to you. It's not a bad thing, but it just might mean you have to remove it from the CI again later -- not a big deal.


steps:
- uses: actions/checkout@v3
Expand All @@ -29,9 +29,9 @@ jobs:
python-version: ${{ matrix.python-version }}

- name: Install Poetry
uses: abatilo/actions-poetry@v2.0.0
uses: abatilo/actions-poetry@v2.1.6
with:
poetry-version: 1.1.14
poetry-version: 1.2.2

- name: Install dependencies
run: poetry install
Expand Down
Loading