Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MCUFRIEND_kbv #82

Closed
ImpulseAdventure opened this issue Nov 27, 2018 · 6 comments
Closed

Support for MCUFRIEND_kbv #82

ImpulseAdventure opened this issue Nov 27, 2018 · 6 comments
Labels
enhancement feedback requested Looking for input from users on idea
Milestone

Comments

@ImpulseAdventure
Copy link
Owner

Today, GUIslice supports a number of display drivers for Arduino including the Adafruit series (eg. Adafruit-ILI9341, etc.) that leverage Adafruit-GFX, as well as TFT_eSPI and Adafruit-GFX-AS (for STM32).

There also exists a number of inexpensive TFT displays manufactured by mcufriend, for which @prenticedavid has built the popular MCUFRIEND_kbv library (primarily targeting UNO shields).

If there is interest, I may consider adding support for these displays as it looks like the integration into GUIslice could be relatively straightforward. As always, the additional display driver support would only be included if selected through config, so it should not burden the core library.

@ImpulseAdventure ImpulseAdventure added enhancement feedback requested Looking for input from users on idea labels Nov 27, 2018
@Pconti31
Copy link
Contributor

Actually, I implemented that six months ago. I'm happy to share the code with you.
It just needs to be updated for 0.10.4 and your new touch parameters.

@ImpulseAdventure
Copy link
Owner Author

That would be great, Paul!

@prenticedavid
Copy link
Contributor

It should be fairly straightforward to use MCUFRIEND_kbv or any other GFX compatible hardware library.

However everything is complicated for the user to configure. Could I suggest that Arduino examples have meaningful names? And that you provide a sketch that simply reads the Touch and displays it.

Surely there are some popular hardware combinations e.g. TFT_eSPI with Red ILI9341/XPT2046 display.
The User would feel comfortable with Bodmer's examples i.e. Touch calibration and graphics

MCUFRIEND shields come with simple Resistive Touch Panel. The Touch pins are shared with the TFT pins.
There is a large range of TFT controllers and different layout of Touch pins. The User can diagnose / calibrate with the MCUFRIEND_kbv examples.

Adafruit Displays come with different Touch panels. Again, there are examples.

David.

@ImpulseAdventure
Copy link
Owner Author

Thanks David for the followup!

I have now renamed all examples to give them a meaningful name (#78).

That's a good suggestion to provide a simplified touch example, as that should help users determine whether the config was correct, the touch screen is responding and whether their calibration is accurate.

Regarding the configuration, in most cases once a standalone TFT_eSPI or Adafruit-GFX example has been confirmed to run, it should be a simple matter to copy the same pinout to the GUIslice config. I have a number of ideas in simplifying the config process and will be revising the guidance in the wiki shortly. I also plan on offering a number of specific CPU+display connection examples with wiring and config -- this should help users get up and running faster too.

As for integrating MCUFRIEND, Pconti31 has sent me a patch for GUIslice that added MCUFRIEND_kbv support. Once I have access to a new mcufriend display that works, I can begin testing and integrating the patch.

Thanks!

@ImpulseAdventure
Copy link
Owner Author

mcufriend support has been added to PR #87

ImpulseAdventure added a commit that referenced this issue Jan 1, 2019
Add support for MCUFRIEND displays for #82
@ImpulseAdventure
Copy link
Owner Author

Closed as merged in #87

@ImpulseAdventure ImpulseAdventure added this to the 0.11.0 milestone Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feedback requested Looking for input from users on idea
Projects
None yet
Development

No branches or pull requests

3 participants