Compatibility updates #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👇 Click on the image for a new way to code review
Legend |
- Improved testing suite, minimizing imports for CI and performance - FireEyeAPI unit test modern/legacy separation - Platforms tested: Windows, Linux - Versions tested: Python2, Python3
- Removed 2 test conditions for now
Improved compatibility for multiple Python versions and API versions
Just a workflow, no code changes.
|
@keathmilligan All tests are passing and everything appears to be working correctly. Please take a look when you get a second. |
|
Looks good - I can't review it since I originally opened the PR. Please go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor tests
Add support for pytest for >= python 3.6 and keep nose for python 2.7 compatibility
Update Joe sandbox jbxapi, handle API changes
Maintain compatibility with older Joe Sandbox versions