Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlashmintHYETHV2 #179

Merged
merged 5 commits into from
Jun 27, 2024
Merged

FlashmintHYETHV2 #179

merged 5 commits into from
Jun 27, 2024

Conversation

ckoopmann
Copy link
Collaborator

Adds support for ERC4626 components.

* @param _component Address of the component
* @param _isERC4626 Boolean indicating if the component is an ERC4626 token
*/
function setERC4626Component(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New function

IWETH(dexAdapter.weth).deposit{ value: _amount }();
return;
}
if (erc4626Components[_component]) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New code block.

IWETH(dexAdapter.weth).withdraw(_amount);
return;
}
if (erc4626Components[_component]) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New code

}
}

function _swapEthForExactToken(address _token, uint256 _amount, DEXAdapterV2.SwapData memory _swapData) internal {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New internal helper function

@ckoopmann ckoopmann requested a review from pblivin0x June 26, 2024 02:49
@ckoopmann ckoopmann force-pushed the flashmint-hyeth-v2 branch from 68d1a65 to 8bfcf11 Compare June 26, 2024 02:54
@@ -37,6 +37,7 @@ export const PRODUCTION_ADDRESSES = {
rsEth: "0xA1290d69c65A6Fe4DF752f95823fae25cB99e5A7",
rswEth: "0xFAe103DC9cf190eD75350761e95403b7b8aFa6c0",
acrossWethLP: "0x28F77208728B0A45cAb24c4868334581Fe86F95B",
morphoRe7WETH: "0x78Fc2c2eD1A4cDb5402365934aE5648aDAd094d0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@pblivin0x pblivin0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@ckoopmann ckoopmann merged commit cf72538 into master Jun 27, 2024
5 checks passed
@ckoopmann ckoopmann deleted the flashmint-hyeth-v2 branch June 27, 2024 02:39
Copy link

🎉 This PR is included in version 0.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants