Make UniswapV3 fee tier configurable #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
changed the title
|
@cgewecke thanks for reviewing! Can you please merge this PR? I don't have merge privileges on this repo. |
|
Oh! Sorry. 😅 Merging now and will publish in the next 30 min. |
|
@edkim This is published now with 0.0.7 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional javascript parameters to define the uniswap fee tier for the function. Currently this is hard-coded as feeAmount.MEDIUM. This update enables the option to use feeAmount.LOW and feeAmount.HIGH, as a parameters for this function, while maintaining backward compatibility.