-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dd-strategies notebook #1038
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…m-dd-strategies-update
View / edit / reply to this conversation on ReviewNB bharat-thotakura commented on 2024-08-29T18:25:49Z nit: ..., we will be creating a pair... |
View / edit / reply to this conversation on ReviewNB bharat-thotakura commented on 2024-08-29T18:25:49Z This is mainly a style preferential comment so the current default works as well and this can be ignored, but it might make it everso less cramped if we added a cell above that was: custom_style = { 'formatter.general.fig_width': 40, 'formatter.general.fig_unit_height': 1 } style = qiskit.visualization.timeline.IQXStandard(**custom_style) and then passed |
oh that's nice, done :) |
@bharat-thotakura thanks for the review! i ended up changing the notebook a little further - it occurred to me that there was no reason to include qiskit's transpilation at all, when the purpose of the notebook is just to compare superstaq's different strategies (the other dd notebook is supposed to be the one comparing to qiskit proper) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
updates the ibmq-dd-strategies notebook to (1) present our newer dd strategies, (2) target ibm_brisbane instead of perth (which has been retired), and (3) use
qiskit-ibm-runtime
's local service instead ofqiskit-ibm-provider
(which has been deprecated). This final change means we no longer require an ibm token for our notebook testalso updates qiskit-superstaq's example-requirements to require
qiskit-ibm-runtime
instead ofqiskit-ibm-provider
. the latter is still used in the ibmq-dd notebook, however this is currently excluded from the notebook check and also relies on outdated devices and strategies and so needs to be updated anyway