Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp of the QCVV interface #1095

Merged
merged 11 commits into from
Dec 12, 2024
Merged

Revamp of the QCVV interface #1095

merged 11 commits into from
Dec 12, 2024

Conversation

cdbf1
Copy link
Contributor

@cdbf1 cdbf1 commented Oct 18, 2024 •
edited
Loading

Revamps the QCVV interface following the observations from #1092

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@cdbf1 cdbf1 mentioned this pull request Oct 18, 2024
Closed
@cdbf1 cdbf1 marked this pull request as ready for review November 18, 2024 13:55
@vtomole vtomole requested a review from richrines1 November 21, 2024 16:33
@cdbf1 cdbf1 mentioned this pull request Nov 26, 2024
Merged
@cdbf1 cdbf1 mentioned this pull request Nov 27, 2024
Open
richrines1
richrines1 reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it. handful of minor comments/questions, otherwise looks great :)

supermarq-benchmarks/supermarq/qcvv/base_experiment.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/base_experiment.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/irb.py Outdated Show resolved Hide resolved
docs/source/apps/supermarq/qcvv/qcvv_irb_css.ipynb Outdated Show resolved Hide resolved
docs/source/apps/supermarq/qcvv/qcvv_xeb_css.ipynb Outdated Show resolved Hide resolved
docs/source/apps/supermarq/qcvv/qcvv_xeb_css.ipynb Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/xeb.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/base_experiment.py Outdated Show resolved Hide resolved
supermarq-benchmarks/supermarq/qcvv/base_experiment.py Show resolved Hide resolved
richrines1
richrines1 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@richrines1 richrines1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cdbf1 cdbf1 merged commit 3d04559 into main Dec 12, 2024
21 checks passed
@cdbf1 cdbf1 deleted the feature/revamp_qcvv_interface branch December 12, 2024 17:21
cdbf1 added a commit that referenced this pull request Dec 18, 2024
@cdbf1 @natibek
Add XEB speckle plots (#1109)
b79efb6 
Adds the functionality to produce "speckle" plots for analyzing XEB
results in the QCVV framework. See Fig S18 of
(https://arxiv.org/pdf/1910.11333) as an example.

Blocked by: #1095

Closes: #1105

---------

Co-authored-by: Nathnael Bekele <135308096+natibek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richrines1 richrines1 richrines1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdbf1 @richrines1