Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin symengine<0.10.0 #418

Merged
merged 2 commits into from
Mar 28, 2023
Merged

pin symengine<0.10.0 #418

merged 2 commits into from
Mar 28, 2023

Conversation

richrines1
Copy link
Contributor

the new version was released today and has been causing our notebook tests to fail (see also Qiskit/qiskit#9857)

@richrines1 richrines1 requested a review from a team as a code owner March 28, 2023 00:22
@richrines1 richrines1 requested review from perlinm and removed request for a team March 28, 2023 00:22
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@teaguetomesh teaguetomesh self-requested a review March 28, 2023 00:41
Copy link
Contributor

@teaguetomesh teaguetomesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The notebook test is failing because of ss#2146

image

otherwise, lgtm

@richrines1
Copy link
Contributor Author

The notebook test is failing because of ss#2146

yep, just wanted to get rid of this new error

@richrines1 richrines1 merged commit ad2325d into main Mar 28, 2023
@richrines1 richrines1 deleted the symengine-pin branch March 28, 2023 01:44
bharat-thotakura pushed a commit that referenced this pull request Apr 10, 2023
the new version was released today and has been causing our notebook
tests to fail (see also
Qiskit/qiskit#9857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants