Feature/implement_IRB_routine #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cdbf1
force-pushed
the
feature/implement_IRB_routine
branch
from
eb5550d to
08c7af7
Compare
cdbf1
force-pushed
the
feature/implement_IRB_routine
branch
from
afe0731 to
ea42062
Compare
cdbf1
force-pushed
the
feature/implement_IRB_routine
branch
from
ea42062 to
6b2f808
Compare
There was a problem hiding this comment.
(Just a couple of preliminary review comments)
In looking at the IRB routine, I have one review comment on base_experiment.py:
- Can we rename
_run_checkto something like_has_raw_data? The former is a bit opaque.
_has_probabilities could also work -- but _has_raw_data makes sense since, inside collect_data, _process_probabilities populates _raw_data anyway.
dowusu-antwi
reviewed
Sep 5, 2024
dowusu-antwi
reviewed
Sep 5, 2024
| @@ -0,0 +1,190 @@ | |||
| { | |||
There was a problem hiding this comment.
Style nit: add supermarq import here (and maybe put all imports in a separate cell)
Reply via ReviewNB
dowusu-antwi
approved these changes
Sep 5, 2024
dowusu-antwi
reviewed
Sep 5, 2024
| @@ -0,0 +1,190 @@ | |||
| { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the interleaved randomized benchmarking routine within the qcvv framework.
Blocked by #992