Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add py.typed to the package definition #107

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

bednar
Copy link
Member

@bednar bednar commented Sep 2, 2024

Proposed Changes

Fixed adding py.typed into package.

Tested via:

mkdir typed
cd typed
python -m venv venv
. venv/bin/activate
python -m pip install git+https://github.com/InfluxCommunity/influxdb3-python.git@typed-definition-setup.py
ls -l venv/lib/python3.11/site-packages/influxdb_client_3/

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review September 2, 2024 10:47
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.12%. Comparing base (e48744e) to head (f263e11).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   55.12%   55.12%           
=======================================
  Files          33       33           
  Lines        2048     2048           
=======================================
  Hits         1129     1129           
  Misses        919      919           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass locally. Good to go.

@bednar bednar added this to the 0.9.0 milestone Sep 13, 2024
@bednar bednar merged commit ee8dd3c into main Sep 13, 2024
13 checks passed
@bednar bednar deleted the typed-definition-setup.py branch September 13, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants