chore: refactor init and extract Query API #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
==========================================
+ Coverage 49.38% 49.75% +0.37%
==========================================
Files 31 32 +1
Lines 2019 2034 +15
==========================================
+ Hits 997 1012 +15
Misses 1022 1022 ☔ View full report in Codecov by Sentry. |
karel-rehor
reviewed
Jun 18, 2024
karel-rehor
requested changes
Jun 18, 2024
There was a problem hiding this comment.
Tests pass locally. Before approving I would like clarification on the __init__ signature of the new QueryAPI class. influxdb3_client_3/query/query_api.py:29. There is a **kwargs parameter, that is not documented and not used. If it is not intended for future use, could it be removed, otherwise could it be added to the code documentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Extracts Query API from the client core in a way similar to Write API. Does not change client public API. The motivation is easier/better maintenance and extending in the future.
Checklist