Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset scroll on markdown navigation #213

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

Valentin271
Copy link
Contributor

Fixes #202

Reset the scroll to top when navigating markdown files.

I think it's worth adding a test for this but I don't know where that would be.

src/main.rs Show resolved Hide resolved
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

It would be nice to add a test, but this part of the code doesn't really have any testing infrastructure setup at the moment. I've been slowly working on getting things more testable, but only bits and pieces support easy testing for now

@CosmicHorrorDev CosmicHorrorDev merged commit dd4536b into Inlyne-Project:main Jan 9, 2024
7 checks passed
@Valentin271 Valentin271 deleted the fix/reset-scroll branch January 9, 2024 20:47
@CosmicHorrorDev CosmicHorrorDev added the C-bug Category: Something isn't working label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scroll doesn't get reset when navigating
2 participants