Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update glyphon to 0.3 #214

Merged

Conversation

Valentin271
Copy link
Contributor

@Valentin271 Valentin271 commented Jan 20, 2024

This updates glyphon the latest version.

There is still one change I need help with (marked below).

EDIT: I'll test the changes locally once I can get it to compile.

@Valentin271
Copy link
Contributor Author

This is the part where I need help.

https://github.com/trimental/inlyne/pull/214/files#diff-32520862cbc569bbe7bbe69197fb360bdf01d9eabd5839d24db034724fa3e766R774-R776

The main problem is that grow is private, I'm pretty sure this was the change made in trimental's fork.
If so we won't be able to update glyphon right?

@CosmicHorrorDev
Copy link
Collaborator

CosmicHorrorDev commented Jan 20, 2024

I believe that you should be able to remove us calling .grow() since growing should be handled internally now. The relevant PR adding the feature upstream is grovesNL/glyphon#34

@Valentin271
Copy link
Contributor Author

You're right, this seems to be working locally without grow.

Thanks for the PR link I'll check it out!

src/text.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@CosmicHorrorDev CosmicHorrorDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good after that one comment is resolved

Huge thanks for getting through these. It's nice to be able to be able to publish to crates.io again

@Valentin271
Copy link
Contributor Author

You're welcome! I wanted to fix that before adding anything else that might be broken by updates.

@CosmicHorrorDev CosmicHorrorDev merged commit 46caaa3 into Inlyne-Project:main Jan 20, 2024
7 checks passed
@Valentin271 Valentin271 deleted the chore/update-glyphon branch January 20, 2024 22:43
@CosmicHorrorDev CosmicHorrorDev mentioned this pull request Jan 20, 2024
8 tasks
@CosmicHorrorDev CosmicHorrorDev added C-refactor Category: Reworking an existing feature A-font Area: Dealing with font loading/rendering A-deps Area: anything and everything to do with dependencies labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-deps Area: anything and everything to do with dependencies A-font Area: Dealing with font loading/rendering C-refactor Category: Reworking an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants