feat: extra keybindings override base #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentin271
commented
Jan 26, 2024
Valentin271
commented
Jan 26, 2024
CosmicHorrorDev
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
Thanks! Really happy with all of this :)
In general refactors are AOK as long as refactors outside the parts covered by the test suite stay relatively small since it's still really easy to regress things without realizing. I'd also love to get enough test coverage to do larger rewrites of things like the interpreter
CosmicHorrorDev
added
C-enhancement
|
Updated to add logs. Thanks I'm really happy with how the implementation turned out too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #188
I suspect this PR will be easier to review by reviewing commits individually (that's why I left them) to understand the reasoning behind the changes. I also left some PR comments to explain some changes.
I refactored the code a bit to be easier to work with, hope that's okay with you.