Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better notification toast #149

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Better notification toast #149

merged 2 commits into from
Oct 30, 2024

Conversation

KwikKill
Copy link
Member

@KwikKill KwikKill commented Oct 30, 2024 •
edited
Loading

Description

Refactor Toast and Error store and components in a single notification module with a store and a component.
Notifications expires after a few seconds.

image
image
image

Checklist

  • I have tested the changes locally and they work as expected.
  • I have tested the responsiveness of the changes and they work as expected.
  • I have assigned the pull request to the appropriate reviewer(s).
  • I have added labels to the pull request, if necessary.

Related Issues

Fix #62

@KwikKill KwikKill added enhancement New feature or request priority: medium to do but later labels Oct 30, 2024
@KwikKill KwikKill requested review from Dyskal and floflo0 October 30, 2024 09:36
@KwikKill KwikKill marked this pull request as ready for review October 30, 2024 09:36
@floflo0
Copy link
Member

floflo0 commented Oct 30, 2024

Looks good, however, we lose the possibility to close the notification which can be useful when notifications goes over the page.
Screenshot 2024-10-30 at 14-33-17 Insalan

@KwikKill
Copy link
Member Author

KwikKill commented Oct 30, 2024 •
edited
Loading

Looks good, however, we lose the possibility to close the notification which can be useful when notifications goes over the page.

This is less required because notification now expires but yes, I'll add it back.

floflo0
floflo0 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@floflo0 floflo0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KwikKill KwikKill merged commit 0bc77fd into dev Oct 30, 2024
3 checks passed
@KwikKill KwikKill deleted the toast branch October 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floflo0 floflo0 floflo0 approved these changes

@Dyskal Dyskal Dyskal approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request priority: medium to do but later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast behavior
3 participants
@KwikKill @floflo0 @Dyskal