Skip to content

Commit

Permalink
fix(bindgen): duplicate JsonCompatible imports for inputs, outputs
Browse files Browse the repository at this point in the history
  • Loading branch information
thewtex committed Sep 26, 2023
1 parent dc86da5 commit 4e38ec5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
8 changes: 0 additions & 8 deletions src/bindgen/typescript/function-module.js
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ function functionModule (srcOutputDir, forNode, interfaceJson, modulePascalCase,
let functionContent = `import {\n`
const usedInterfaceTypes = new Set()
let needMountDirs = false
let needJsonCompatible = false
const pipelineComponents = ['inputs', 'outputs', 'parameters']
pipelineComponents.forEach((pipelineComponent) => {
interfaceJson[pipelineComponent].forEach((value) => {
Expand All @@ -49,10 +48,6 @@ function functionModule (srcOutputDir, forNode, interfaceJson, modulePascalCase,
needMountDirs = true
return
}
if (interfaceType === 'JsonCompatible' && pipelineComponent === 'inputs') {
needJsonCompatible = true
return
}
if (!(pipelineComponent === 'inputs' && interfaceType === 'BinaryStream')) {
usedInterfaceTypes.add(interfaceType)
}
Expand All @@ -65,9 +60,6 @@ function functionModule (srcOutputDir, forNode, interfaceJson, modulePascalCase,
functionContent += ' InterfaceTypes,\n'
functionContent += ' PipelineOutput,\n'
functionContent += ' PipelineInput,\n'
if (needJsonCompatible) {
functionContent += ' JsonCompatible,\n'
}
if (forNode) {
functionContent += ' runPipelineNode\n'
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/bindgen/typescript/types-require-import.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
const typesRequireImport = ['Image', 'Mesh', 'PolyData', 'TextFile', 'BinaryFile', 'TextFile', 'BinaryFile']
const typesRequireImport = ['Image', 'Mesh', 'PolyData', 'TextFile', 'BinaryFile', 'TextFile', 'BinaryFile', 'JsonCompatible']

export default typesRequireImport

0 comments on commit 4e38ec5

Please sign in to comment.