Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add contributing documentation file #937

Merged

Conversation

jhlegarreta
Copy link
Member

@jhlegarreta jhlegarreta commented Sep 16, 2023

Add contributing documentation file: cross-reference the contributing
section of the hacking_itk_wasm.md file.

CONTRIBUTING.md Outdated
@@ -0,0 +1 @@
{{docs/development/hacking_itk_wasm.md#contributing}}
Copy link
Member Author

@jhlegarreta jhlegarreta Sep 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure at all that this will work, especially due to referencing to a section; the file preview does not seem to be as expected:
https://github.com/InsightSoftwareConsortium/itk-wasm/blob/a51264d771371859cf0f0ab756a6d9df8b0a4795/CONTRIBUTING.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since GitHub does not render it, what you think about something like,

Please see [our contributing documentation](https://wasm.itk.org/en/latest/development/hacking_itk_wasm.html) for more information.

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few attempts in a test repository to see if the transclusion worked but did not succeed. I do not like the cross-reference solution very much, but I adopted it: instead of using the HTML link, I used a relative link directly to the section of interest in the Markdown file at issue.

Add contributing documentation file: cross-reference the contributing
section of the `hacking_itk_wasm.md` file.
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta thank you!!

@thewtex thewtex merged commit 3136394 into InsightSoftwareConsortium:main Sep 19, 2023
69 of 70 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-b.140 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jhlegarreta jhlegarreta deleted the AddContributingDoc branch September 19, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants