Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the PythonGetNameOfClass test #96

Closed
thewtex opened this issue Nov 5, 2018 · 3 comments · Fixed by #643
Closed

Re-enable the PythonGetNameOfClass test #96

thewtex opened this issue Nov 5, 2018 · 3 comments · Fixed by #643
Labels
area:Core Issues affecting the Core module area:Python wrapping Python bindings for a class

Comments

@thewtex
Copy link
Member

thewtex commented Nov 5, 2018 •
edited
Loading

This test currently crashes unreliably with

itkTestDriver: Process exception: Illegal instruction

on macOS

or

itkTestDriver: Process exception: Segmentation fault

on Linux.
@thewtex thewtex added area:Python wrapping Python bindings for a class area:Core Issues affecting the Core module labels Nov 5, 2018
thewtex added a commit to thewtex/ITK that referenced this issue Nov 5, 2018
@thewtex
BUG: Disable PythonGetNameOfClass test
02854e8 
This test currently fails unreliably. Temporarily disabling to enable CI
testing of the toolkit.

Eventually, this should be addressed and re-enabled. See InsightSoftwareConsortium#96.
This was referenced Nov 5, 2018
Merged
Closed
@stale
Copy link

stale bot commented Mar 5, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status:Backlog Postponed without a fixed deadline label Mar 5, 2019
@maekclena
Copy link
Contributor

The error comes from ScanlineFilterCommon::New when trying to register its smart pointer instead executes the overriding version with m_EnclosingFilter still null.

It seems to me like this class should inherit ImageToImageFilter instead of using composition.

@stale stale bot removed the status:Backlog Postponed without a fixed deadline label Mar 22, 2019
@thewtex
Copy link
Member Author

thewtex commented Mar 22, 2019

The error comes from ScanlineFilterCommon::New when trying to register its smart pointer instead executes the overriding version with m_EnclosingFilter still null.

Good catch! 🦅 👁️

It seems to me like this class should inherit ImageToImageFilter instead of using composition.

Makes sense -- want to create a PR?

@maekclena maekclena mentioned this issue Mar 28, 2019
Merged
vfonov added a commit to vfonov/ITK that referenced this issue Oct 3, 2019
@vfonov
MINC 2019-10-02 (ebf6eee8)
351cfd7 
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.

$ git archive --prefix=upstream-minc/ ebf6eee8 -- 
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
 | tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' 44fae20d..ebf6eee8

Vladimir S. FONOV (6):
      d51d37b9 Updating passing MI2_ flags to netcdf, addresses InsightSoftwareConsortium#94
      799c1df7 Updated configuration for UseLIBMINC.cmake
      1d4565b0 Addresses compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      bd84a98d more fixes for compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      2404369b Ignoring VScode files
      ebf6eee8 Fixes InsightSoftwareConsortium#96

Change-Id: Iac40bde5e6865644f4b1c1ebfba925b5b23145a0
vfonov added a commit to vfonov/ITK that referenced this issue Oct 3, 2019
@vfonov
MINC 2019-10-02 (ebf6eee8)
808ff6c 
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.

$ git archive --prefix=upstream-minc/ ebf6eee8 -- 
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
./check_clock_gettime.c | tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' 44fae20d..ebf6eee8

Vladimir S. FONOV (6):
      d51d37b9 Updating passing MI2_ flags to netcdf, addresses InsightSoftwareConsortium#94
      799c1df7 Updated configuration for UseLIBMINC.cmake
      1d4565b0 Addresses compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      bd84a98d more fixes for compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      2404369b Ignoring VScode files
      ebf6eee8 Fixes InsightSoftwareConsortium#96

Change-Id: Ic62b1d1b8ffe648142e5c3bb809fce6da06aceb8
vfonov added a commit to vfonov/ITK that referenced this issue Oct 3, 2019
@vfonov
MINC 2019-10-03 (592dd487)
db9ccc6 
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.

$ git archive --prefix=upstream-minc/ 592dd487 -- 
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
./check_clock_gettime.c | tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' 44fae20d..592dd487

Vladimir S. FONOV (7):
      d51d37b9 Updating passing MI2_ flags to netcdf, addresses InsightSoftwareConsortium#94
      799c1df7 Updated configuration for UseLIBMINC.cmake
      1d4565b0 Addresses compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      bd84a98d more fixes for compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      2404369b Ignoring VScode files
      ebf6eee8 Fixes InsightSoftwareConsortium#96
      592dd487 Fixed according to ITK style

Change-Id: I2b318947d4758398ed2d403aa8c90c83a6793ae6
vfonov added a commit to vfonov/ITK that referenced this issue Oct 3, 2019
@vfonov
MINC 2019-10-03 (592dd487)
54b5ef4 
Run the UpdateFromUpstream.sh script to extract upstream MINC
using the following shell commands.

$ git archive --prefix=upstream-minc/ 592dd487 -- 
./ChangeLog
./volume_io
./libsrc
./libsrc/minc_compat.h
./libcommon/minc_config.h
./libcommon/minc_config.c
./libsrc/minc_format_convert.c
./libsrc/value_conversion.c
./libsrc/hdf_convenience.c
./libcommon/read_file_names.c
./libsrc/minc_simple.c
./libcommon/time_stamp.h
./libsrc/hdf_convenience.h
./libsrc/type_limits.h
./libcommon/read_file_names.h
./libsrc/minc_varlists.h
./libcommon/restructure.h
./libsrc/nd_loop.h
./libcommon/restructure.c
./libsrc/minc_simple.h
./libsrc/strdup.c
./libsrc/minc_useful.h
./libsrc/minc_convenience.c
./libsrc/minc_basic.h
./libsrc/minc_compat.c
./libcommon/time_stamp.c
./libsrc/voxel_loop.h
./libsrc/minc_routines.h
./libsrc/minc_private.h
./libsrc/netcdf_convenience.c
./libsrc/voxel_loop.c
./libsrc/dim_conversion.c
./libsrc/minc_format_convert.h
./libsrc/nd_loop.c
./libcommon/ParseArgv.h
./libcommon/minc_error.c
./libcommon/minc_error.h
./libsrc/minc_structures.h
./libsrc/minc.h
./libsrc/image_conversion.c
./libcommon/ParseArgv.c
./libcommon/minc_common_defs.h
./COPYING
./UseLIBMINC.cmake.in
./NEWS
./AUTHORS
./libsrc2/m2util.c
./libsrc2/minc2_defs.h
./libsrc2/minc2_api.h
./libcommon/minc2_error.h
./libsrc2/grpattr.c
./libsrc2/hyper.c
./libsrc2/minc_compat2.h
./libcommon/minc2_error.c
./libsrc2/record.c
./libsrc2/volume.c
./libsrc2/datatype.c
./libsrc2/volprops.c
./libsrc2/valid.c
./libsrc2/convert.c
./libsrc2/free.c
./libsrc2/dimension.c
./libsrc2/label.c
./libsrc2/minc2.h
./libsrc2/minc2_private.h
./libsrc2/slice.c
./libsrc2/minc2_structs.h
./CMakeLists.txt
./nifti
./LIBMINCConfig.cmake.in
./README.release
./INSTALL
./config.h.cmake
./README
./check_clock_gettime.c | tar x
$ git shortlog --perl-regexp --author='^((?!Kitware Robot).*)$' --no-merges --abbrev=8 --format='%h %s' 44fae20d..592dd487

Vladimir S. FONOV (7):
      d51d37b9 Updating passing MI2_ flags to netcdf, addresses InsightSoftwareConsortium#94
      799c1df7 Updated configuration for UseLIBMINC.cmake
      1d4565b0 Addresses compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      bd84a98d more fixes for compilation with newer Visual Studio, addresses InsightSoftwareConsortium#1115
      2404369b Ignoring VScode files
      ebf6eee8 Fixes InsightSoftwareConsortium#96
      592dd487 Fixed according to ITK style

Change-Id: I4eedbb8498aa39811b3df808b2356d54949a98e2
@hjmjohnson hjmjohnson mentioned this issue Apr 11, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:Core Issues affecting the Core module area:Python wrapping Python bindings for a class
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: Cleanup python wrapping tests
2 participants
@thewtex @maekclena