BUG: fix installation of the generated file expat_config.h #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:ThirdParty
dzenanz
reviewed
Oct 8, 2021
| @@ -195,7 +195,7 @@ INSTALL(TARGETS ITKEXPAT | |||
| INSTALL(FILES | |||
| ${ITK3P_EXPAT_BINARY_DIR}/expatDllConfig.h | |||
| ${ITK3P_EXPAT_SOURCE_DIR}/expat.h | |||
| ${ITK3P_EXPAT_SOURCE_DIR}/expat_config.h | |||
| ${CMAKE_CURRENT_BINARY_DIR}/expat_config.h | |||
There was a problem hiding this comment.
Should this be ITK3P_EXPAT_BINARY_DIR, same as two lines above?
There was a problem hiding this comment.
Should this be
ITK3P_EXPAT_BINARY_DIR, same as two lines above?
My patch was based on how expat_config.h is generated. 9b74f7b accounts for your suggestion and makes the generation of expat_config.h consistent. I'm not sure if ITK3P_EXPAT_SOURCE_DIR and CMAKE_CURRENT_BINARY_DIR can differ and, if yes, what's the best solution... @agravgaard may want to comment on his code.
thewtex
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.