Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add bufferedRegion to dict_from_image representation #4633

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented May 1, 2024

Optional specification of the BufferedRegion, which is a subset of the
LargestPossibleRegion. Addresses #4267.

The LargestPossibleRegion's Index is assumed to be trivial (zeros).

Also update the NumPy bridge to correctly use the BufferedRegion instead
of the LargestPossibleRegion for the array shape.

Optional specification of the BufferedRegion, which is a subset of the
LargestPossibleRegion. Addresses InsightSoftwareConsortium#4267.

The LargestPossibleRegion's Index is assumed to be trivial (zeros).

Also update the NumPy bridge to correctly use the BufferedRegion instead
of the LargestPossibleRegion for the array shape.
@thewtex thewtex requested a review from tbirdso May 1, 2024 16:45
@github-actions github-actions bot added type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances area:Python wrapping Python bindings for a class type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Bridge Issues affecting the Bridge module labels May 1, 2024
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@thewtex thewtex added this to the ITK 5.4.0 milestone May 2, 2024
@thewtex thewtex merged commit 3fe87c1 into InsightSoftwareConsortium:master May 3, 2024
14 checks passed
@thewtex thewtex deleted the image-dict-buffered-region-array branch May 3, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Bridge Issues affecting the Bridge module area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants