Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add BUILD_SHARED_LIBS to macOS build CI configuration #89

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Nov 5, 2018

See the CONTRIBUTING guide. Specifically:

Start ITK commit messages with a standard prefix (and a space):

  • BUG: fix for runtime crash or incorrect result
  • COMP: compiler error or warning fix
  • DOC: documentation change
  • ENH: new functionality
  • PERF: performance improvement
  • STYLE: no logic impact (indentation, comments)
  • WIP: Work In Progress not ready for merge

Provide a short, meaningful message that describes the change you made.

When the PR is based on a single commit, the commit message is usually left as the PR message.

A reference to a related issue or pull request in your repository. You can automatically close a related issues using keywords

@mentions of the person or team responsible for reviewing proposed changes.

Thanks for contributing to ITK!

@kwrobot kwrobot added temp and removed temp labels Nov 6, 2018
@mathstuf
Copy link
Contributor

mathstuf commented Nov 6, 2018

Do: check

@mathstuf
Copy link
Contributor

mathstuf commented Nov 6, 2018

Ah, this is ignored because it targets the python-builds branch. @bradking

@bradking
Copy link
Member

bradking commented Nov 6, 2018

@thewtex didn't you ask for python-builds to be a nightly follower of master? There should be no PRs targeting it directly.

@thewtex
Copy link
Member Author

thewtex commented Nov 6, 2018

python-builds is currently used to trigger Python builds. But, this configuration is a WIP and may changed.

Copy link
Member

@hjmjohnson hjmjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase after the VXL updates in #175 are in place.

@thewtex
Copy link
Member Author

thewtex commented Feb 15, 2019

We prefer static builds on macOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants