Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Automate deploy to PyPI #25

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

tbirdso
Copy link
Collaborator

@tbirdso tbirdso commented Nov 15, 2023

Automatically deploys wheels to the Python Package Index on tag.

Depends on PYPI_PASSWORD secret.

Closes #9

@tbirdso tbirdso requested a review from thewtex November 15, 2023 20:45
@tbirdso tbirdso changed the title ENH: Automate deploy to PyPI Draft: ENH: Automate deploy to PyPI Nov 15, 2023
@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 15, 2023

@thewtex Would you please create a PyPI access token and add it as a itk-dreg repository secret? https://itkpythonpackage.readthedocs.io/en/master/Build_ITK_Module_Python_packages.html?highlight=twine#automate-pypi-package-uploads

Automatically deploys wheels to the Python Package Index on tag
@tbirdso tbirdso changed the title Draft: ENH: Automate deploy to PyPI ENH: Automate deploy to PyPI Nov 15, 2023
@tbirdso tbirdso requested a review from dzenanz November 16, 2023 16:29
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tbirdso thanks!

A few notes inline to transition to enable Trusted Publishing instead of using token / secrets, which is modern / preferred. We could not enable this in the ITK Remote Module Action yet because Trusted Publishing is not supported in reusable workflows.

@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 16, 2023

Hi @thewtex , I do not see your suggested changes on the PR?

@thewtex
Copy link
Member

thewtex commented Nov 16, 2023

@tbirdso sorry, not sure what happened -- added as a Single Comment.

@tbirdso
Copy link
Collaborator Author

tbirdso commented Nov 16, 2023

@thewtex Pushed a last commit on my way out the door, feel free to push to my dev branch if there are other changes required to get this through. Thanks!

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@thewtex thewtex merged commit 631fc0c into InsightSoftwareConsortium:main Nov 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate package delivery in CI/CD
2 participants