Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build docs script #373

Closed
jessesquires opened this issue Dec 27, 2016 · 2 comments
Closed

Fix build docs script #373

jessesquires opened this issue Dec 27, 2016 · 2 comments

Comments

@jessesquires
Copy link
Contributor

Because of macOS support and adding a Common/ sub-directory, the jazzy build script is broken again.

Same problem as #55 (i.e. realm/jazzy#667). We'll need another workaround, similiar to 7163cf8.

However, this workaround will be significantly more complicated. We need to move the Common/ files to the tmp dir IGListKit/, then we need to move only those files back.

Relevant issues: #235, #328, #270, #53, #368, #365

@Sherlouk
Copy link
Contributor

Can we rely on git? 🤔 Merge all the directories then git reset the source directory leaving just updated docs.

Alternative being we iterate the files, add to an array, move, run jazzy, then move back.

@jessesquires
Copy link
Contributor Author

Alternative being we iterate the files, add to an array, move, run jazzy, then move back.

We'll have to do this. IG uses mercurial internally.

facebook-github-bot pushed a commit that referenced this issue Jan 28, 2017
Summary:
Fixed build-docs script. Workaround for #373
Closes #447

Differential Revision: D4479613

Pulled By: rnystrom

fbshipit-source-id: abc61ed11ae01efbbe9b5aaab2036501d269f9c7
jessesquires pushed a commit that referenced this issue Feb 7, 2017
Summary:
Fixed build-docs script. Workaround for #373
Closes #447

Differential Revision: D4479613

Pulled By: rnystrom

fbshipit-source-id: abc61ed11ae01efbbe9b5aaab2036501d269f9c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants