Remove criterion-cycles-per-byte dependency and related benchmark mea…

…surement (#995)
Instagram · Aug 26, 2023 · b28777e · b28777e
1 parent c2d1761
commit b28777e
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 164 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -168,6 +168,11 @@ jobs:
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           args: --manifest-path=native/Cargo.toml --all-features
+      - name: compile-benchmarks
+        uses: actions-rs/cargo@v1
+        with:
+          command: bench
+          args: --manifest-path=native/Cargo.toml --no-run
 
   rustfmt:
     name: Rustfmt

diff --git a/native/Cargo.lock b/native/Cargo.lock
diff --git a/native/libcst/Cargo.toml b/native/libcst/Cargo.toml
@@ -41,7 +41,6 @@ libcst_derive = { path = "../libcst_derive" }
 
 [dev-dependencies]
 criterion = { version = "0.4.0", features = ["html_reports"] }
-criterion-cycles-per-byte = "0.1"
 difference = "2.0.0"
 
 [[bench]]

diff --git a/native/libcst/benches/parser_benchmark.rs b/native/libcst/benches/parser_benchmark.rs
@@ -11,7 +11,6 @@ use std::{
 use criterion::{
     black_box, criterion_group, criterion_main, measurement::Measurement, BatchSize, Criterion,
 };
-use criterion_cycles_per_byte::CyclesPerByte;
 use itertools::Itertools;
 use libcst_native::{
     parse_module, parse_tokens_without_whitespace, tokenize, Codegen, Config, Inflate,
@@ -120,7 +119,7 @@ pub fn parse_into_cst_benchmarks<T: Measurement>(c: &mut Criterion<T>) {
 
 criterion_group!(
     name=benches;
-    config = Criterion::default().with_measurement(CyclesPerByte);
+    config=Criterion::default();
     targets=parser_benchmarks, codegen_benchmarks, inflate_benchmarks, tokenize_benchmarks, parse_into_cst_benchmarks
 );
 criterion_main!(benches);