Skip to content

Commit

Permalink
feat: [LSSP-625] update develop to v6 (#43)
Browse files Browse the repository at this point in the history
* LuponMedia Bid Adapter: add adapter back to prebid master (#7602)

* LuponMedia BidAdapter 5.X

* manually try to kick off circleci tests

* kick off tests

* kick off tests

* Update luponmediaBidAdapter.js

using isFn from utils

Co-authored-by: adxpremium <support@luponmedia.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* VIS.X Bid Adapter: check ad slot existence (#7730)

* VIS.X: add ad slot check

* VIS.X: update ad slot check helpers

Co-authored-by: Vladimir Fedoseev <vladimir.fedoseev@yoc.com>

* showheroes-bs Bid Adapter: fix for outstream render (#7604)

* add ShowHeroes Adapter

* ShowHeroes adapter - expanded outstream support

* Revert "ShowHeroes adapter - expanded outstream support"

This reverts commit bfcdb913b52012b5afbf95a84956b906518a4b51.

* ShowHeroes adapter - expanded outstream support

* ShowHeroes adapter - fixes (#4222)

* ShowHeroes adapter - banner and outstream fixes (#4222)

* ShowHeroes adapter - description and outstream changes (#4222)

* ShowHeroes adapter - increase test coverage and small fix

* ShowHeroes Adapter - naming convention issue

* Mixed AdUnits declaration support

* ITDEV-4723 PrebidJS adapter support with SupplyChain module object

* ITDEV-4723 Fix tests

* ITDEV-4723 New entry point

* showheroes-bsBidAdapter: Add support for advertiserDomains

* showheroes-bsBidAdapter: hotfix for outstream render

* showheroes-bsBidAdapter: update renderer url

Co-authored-by: veranevera <vera.yukhina@showheroes.com>
Co-authored-by: Elizaveta Voziyanova <44549195+h2p4x8@users.noreply.github.com>

* Revert "showheroes-bs Bid Adapter: fix for outstream render (#7604)" (#7734)

This reverts commit 23f4da7b503d8e87da52837d454e62c22589c2d1.

* Testing Browserlist: remove browsers for testing that are not being built as a target (#7696)

* Build: remove browsers for testing not building to

* update chrome version

* change chrome to v95

* upgrade to v93 for firefox

* try latest flag with chrome

* update to latest can-i-use for new browsers

* Revert "update to latest can-i-use for new browsers"

This reverts commit 9e07037d3461ea098ca785ebabe33c41dab7afe7.

* change to latest version and oldest chrome

* fix os for safari

* update big sur browser

* try again with mac version os

* fix typo

* fix catalina safari version

* update concurrency

* freewheel-ssp Bid Adapter: add schain in request params (#7504)

* freewheel add schain in the request

* Fix an error on test case

* Update freewheel-sspBidAdapter_spec.js

Update test case

* Update freewheel-sspBidAdapter_spec.js

fix the test

* Update freewheel-sspBidAdapter_spec.js

Fix the test error

* UserID Module: allow userid to ppid sync (#7681)

* sync PPID with googletag

* dont need to export

* add log warning if not right length

* EMX Digital Bid Adapter: add GPID support (#7720)

* adding ccpa support for emx_digital adapter

* emx_digital ccpa compliance: lint fix

* emx 3.0 compliance update

* fix outstream renderer issue, update test spec

* refactor formatVideoResponse function to use core-js/find

* Add support for schain forwarding

* Resolved issue with Schain object location

* prebid 5.0 floor module and advertiserDomain support

* liveramp idl and uid2.0 support for prebid

* gpid support

* remove utils ext

* remove empty line

* remove trailing spaces

* move gpid test module

* move gpid test module

* removing trailing spaces from unit test

* remove comments from unit test

Co-authored-by: Nick Colletti <nick.colletti@emxdigital.com>
Co-authored-by: Nick Colletti <gnomish@gmail.com>
Co-authored-by: Kiyoshi Hara <Kiyoshi.Hara@emxdigital.com>
Co-authored-by: Dan Bogdan <daniel.bogdan@emxdigital.com>
Co-authored-by: Jherez Taylor <jherez.taylor@emxdigital.com>
Co-authored-by: EMXDigital <emxdigital@emxdigital.com>
Co-authored-by: Rakesh Balakrishnan <Rakesh.Balakrishnan@emxdigital.com>
Co-authored-by: EMX Digital <43830380+EMXDigital@users.noreply.github.com>
Co-authored-by: Kevin <kevin.hagens@brealtime.com>

* Limelight Digital Bid Adapter: Add optional Publisher ID field (#7706)

* adyoulike Bid Adapter: Add userIds to bidrequest (#7660)

* add required clickurl in every native adrequest

* allows the native response to be given as is to prebid if possible

* add unit tests on new Native case

* Handle meta object in bid response with default addomains array

* fix icon retrieval in Native case

* Update priorities in case of multiple mediatypes given

* improve robustness and fix associated unit test on picture urls

* add support for params.size parameter

* add unit test on new size format

* Makes sure the playerSize format is consistent

* enable Vast response on bidder adapter

* fix lint errors

* add test on Vast format case

* add userId to bidrequest

* revert package-lock.json changes

* add first-party data support to beachfront adapter (#7733)

Co-authored-by: John Salis <john@beachfront.com>

* Prebid 6.2.0 Release

* Increment pre version

* SharedID module: update tests to assert on behavior rather than logs (#7738)

Update tests that fail spuriously: https://github.com/prebid/Prebid.js/issues/7355
I was not able to reproduce the failures, but in debugging I ruled out the possibility of module loading order and I believe the most likely culprit is other tests asynchronously calling `utils.logInfo` that sometimes happen in-between these tests' setup and assertions.

This may not be the real issue, but IMO testing log messages makes little sense anyway, so I updated them to test the actual SOT behavior.

* gumgum & adagio Bid Adapters: remove extra defensive code to solve lgtm alert (#7737)

* Update gumgumBidAdapter.js

* Update adagioBidAdapter.js

* 33acrossBidAdapter: Add Support for SRA (#7703)

* SRA support

* apply code review feedback SRA

* removed redundant config check

* Replace not-supported array flat method.

Co-authored-by: Carlos Felix <carlos.felix@33across.com>

* Remove redundant alias (#7742)

Fix an issue with the `gdprEnforcement` module. See #7741

* Lotame panorama id submodule: handle consent (#7644)

* feat: Add handling for a custom client id
feat: Send us privacy string

* test: Add test case to make sure the expiry is also not touched and update the mocked response

Co-authored-by: Mike Marcus <mike@lotame.com>

* Yahoo SSP Bid Adapter: interstitial fix  (#7746)

* ortb2Imp.instl

* ortb2Imp.instl unit-test

* numeric boolean validations

* refacotor for false 0

* tests stable

* Kinesso fixing the endpoint construction (#7743)

Co-authored-by: skocheri <skocheri@rubiconproject.com>

* VidoomyBidAdapter: fix video mediatype sizes format (#7716)

* fix: add delay between cookie sync calls

* fix(VidoomyBidAdapter): use default triggerPixel

* fix: use getUserSyncs hook to sync cookies

* fix: handle 204 no response without error log

* chore: refactor getUserSyncs

* test: update vidoomyBidAdapter tests

* fix: remove Macro

* fix: query params

* fix: gdpr consent

* fix: vidoomyBidAdapter tests

* fix: use USP_CONSENT in cookie sync urls

* fix(vidoomyBidAdapter): sizes format for video mediatype

* fix: vast xml

* fix: send gdpr as string

* chore: add adUnitCode to prebid request

* Prebid core: move generation of 'installedModules' to babel (#7739)

`pbjs.installedModules` does not work correctly when using prebid as an npm dependency (https://github.com/prebid/Prebid.js/issues/7287), because it's generated by a gulp task.

This moves generation of `installedModules` to the `pbjsGlobals` babel plugin that we ask npm consumers to use for prebid.

* Add 'targetingControls.addTargetingKeys' configuration option (#7690)

This adds 'addTargetingKeys' as a config option that means 'allow all default targeting keys, plus these'.

https://github.com/prebid/Prebid.js/issues/7249

* add alias futureads (#7753)

Co-authored-by: atkachov <atkachov@admixer.ua>

* Weborama Rtd Provider: access user profiles in local storage and add support to wam2gam and smartadserver (#7728)

* update .submodules.json to include weborama rtd

update .submodules.json to include weborama rtd submodule

* fix jsdoc

* add support to wam2gam

* fix unit test

* fix bad copy paste

* save dev

* add feature

* rename properties

* update unit tests

* fix doc

* fix doc ~

* fix doc 3

* rename bigsea contextual

* rename wam2gam

* refactor code

* rename setGAMTargeting

* improve doc, example

* update conf

* fix doc

* fix identation

* fix identation 2

* remove empty line into end

* remove empty line 2

* fix jsdoc

* add support to wam2gam

* fix unit test

* fix bad copy paste

* save dev

* add feature

* rename properties

* update unit tests

* fix doc

* fix doc ~

* fix doc 3

* rename bigsea contextual

* rename wam2gam

* refactor code

* rename setGAMTargeting

* improve doc, example

* update conf

* fix doc

* fix identation

* fix identation 2

* remove empty line into end

* remove empty line 2

* add intersection RtdProvider and spec (#7710)

Co-authored-by: atkachov <atkachov@admixer.ua>

Co-authored-by: AdmixerTech <35560933+AdmixerTech@users.noreply.github.com>
Co-authored-by: atkachov <atkachov@admixer.ua>

* Zeta Ssp Bid Adapter: vast xml for bid (#7740)

* vastXml as bid.ad

* test added

* logic with ext.bidtype

* fix tests

* fix tests(3)

* change .md for video support sample

Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

* NextMillennium Bid Adapter: add getUserSyncs function (#7749)

* Add getUserSyncs function

* add unit tests

* add unit tests

Co-authored-by: mifanich <mihail.ivanchenko@nextmillennium.io>

* BeOp Bid Adapter: fix tracking params (#7759)

* [BeOp adapter] Fix tracking params

* Missing comma

* PBS Bid adapter: timeout user syncs if they never load (#7744)

* PBS Bid adapter: timeout user syncs if they never load

In some situations the browser never triggers load/error events for user syncs, so the PBS adapter remains stuck (https://github.com/prebid/Prebid.js/issues/6354). This adds a timeout for image/iframe syncs.

* Clear timeout in utils.waitForElementToLoad

* add one more get param to be forwarded (#7745)

* Update Criteo Fast Bid version (#7767)

* TargetVideo Bid Adapter: add new bid adapter (#7718)

* TargetVideo bid adapter

* TargetVideo bid adapter

* TargetVideo bid adapter

* TargetVideo Bid Adapter update

* TargetVideo Bid Adapter implementing requested changes

* Adman Bidder Adapter: add lotamePanoramaId (#7763)

* Add Adman bid adapter

* Add supportedMediaTypes property

* Update ADman Media bidder adapter

* Remove console.log

* Fix typo

* revert package-json.lock

* Delete package-lock.json

* back to original package-lock.json

* catch pbjs error

* catch pbjs error

* catch pbjs error

* log

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* Update admanBidAdapter.js

add consnet to sync url

* Update admanBidAdapter.js

fix import

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

check consent object data availability

* сompatible with prebid v5

* add Lotame Panorama ID

Co-authored-by: minoru katogi <mkatogi@gmail.com>
Co-authored-by: minoru katogi <m_katogi@hotmail.com>
Co-authored-by: ADman Media <admanmedia@users.noreply.github.com>
Co-authored-by: SmartyAdman <adman@localhost.localdomain>

* ZetaSspBidAdapter: provide media type (#7762)

* provideMediaType

* checkstyle issue

Co-authored-by: Surovenko Alexey <surovenko.alexey@gmail.com>

* Fix GDPR consent choice capture (#7779)

* Mediasquare bidder: remove old user sync method (#7780)

* remove old userSyncs method

* Update mediasquareBidAdapter.js

* Update mediasquareBidAdapter.js

* Update mediasquareBidAdapter_spec.js

* PubCommonID module: use topmost domain for cookie storage (#7773)

This reintroduces logic to have sharedIdSystem/pubCommonID use the TLD for cookie storage

* adxcgBidAdapter: updated backend protocol (#7750)

* adxcgBidAdapter: updated backend protocol

* adxcgBidAdapter: changed onBidWon from ajax() to triggerPixel()

Co-authored-by: dev adxcg.com <mark.vreg@gmail.com>

* Adnuntius Bid Adapter: no cookie feature. (#7768)

* Added option to pass a user id through ortb2.

* check if use cookie is present in config, and use it accordingly.

* Adding test for no cookie url addition.

* AdDefend Bidder: added gdprApplies to bid request parameters (#7782)

Co-authored-by: Mitschi <mitschi@addefend.com>

* fix usersync gdpr (#7785)

* Ventes Bid Adapter: fix web support and code maintenance (#7766)

* Ventes Avenues initial changes

* Ventes Avenues initial changes

* Support Web Placments

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placements

* Support Web Placments

* Update for 'Adapters that may not handle GDPR-Applies correctly #7775' (#7788)

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

* PBS Bid Adapter: do not pass aspectratios in ORTB2 ext data if native image definition doesn't have ratio_height/ratio_width (#7722)

* Prebid server adapter: do not pass aspectratios in ORTB2 ext data if native image definition does not have ratio_height/ratio_width

* Prebid server adapter: include all valid aspect ratios in ext.aspectratios

* NextMillennium Bid Adapter: refresh_count for adUnitCode is added (#7754)

* refresh count

* Update tests

Co-authored-by: mifanich <mihail.ivanchenko@nextmillennium.io>

* Handle consent case where GDPR doesn't apply (#7783)

* Colossus SSP Bidder Adapter: add onBidWon() (#7758)

* add video&native traffic colossus ssp

* Native obj validation

* Native obj validation #2

* Added size field in requests

* fixed test

* fix merge conflicts

* move to 3.0

* move to 3.0

* fix IE11 new URL issue

* fix IE11 new URL issue

* fix IE11 new URL issue

* https for 3.0

* add https test

* add ccp and schain features

* fix test

* sync with upstream, fix conflicts

* Update colossussspBidAdapter.js

remove commented code

* Update colossussspBidAdapter.js

lint fix

* identity extensions

* identity extensions

* fix

* fix

* fix

* fix

* fix

* add tests for user ids

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* add gdpr support

* add gdpr support

* id5id support

* Update colossussspBidAdapter.js

add bidfloor parameter

* Update colossussspBidAdapter.js

check bidfloor

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter_spec.js

* use floor module

* Revert "use floor module"

This reverts commit f0c5c248627567e669d8eed4f2bb9a26a857e2ad.

* use floor module

* update to 5v

* fix

* add uid2 and bidFloor support

* fix

* add pbadslot support

* fix conflicts

* add onBidWon

* refactor

* add test for onBidWon()

* fix

Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com>

* RTD Module: add 'onBidRequest' event handler for RTD submodules (#7729)

* RTD: Add 'onBidRequest' event handler for RTD submodules

https://github.com/prebid/Prebid.js/issues/7078

* RTD module: update documentation

* Prebid 6.3.0 Release (#7795)

* Increment pre version

* Improve Digital adapter: support for Google's additional consent (#7787)

* HBT-156: Added Google's additional consent (#1)

* HBT-156: Added Google's additional consent

* HBT-156: Code refactored

Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>

* Update improvedigitalBidAdapter.js

Updated version

Co-authored-by: Samiul Amin Shanto <93644987+samiul-shanto@users.noreply.github.com>
Co-authored-by: Faisal Islam <faisal.islam@vivacomsolutions.com>

* CircleCi Config: change to npm ci in testing workf (#7732)

* Build system: improve build for development workflow (#7778)

* Build system: improve build for development workflow

This adds a "test-only" gulp task that runs only tests (without clean/lint) and makes the single-spec test environment consistent with the whole-suite case.

* Build system: remove tests from 'serve-fast' task; add 'serve-and-test' task

* update gpid / adslot logic (#7794)

* Pubx.ai Analytics Adapter: added additional fields to the Auction object (#7723)

* Update: Added additional fields to auction object

* Removed export from getStorage function

* Aniview Bid Adapter: add a new alias (#7807)

* Support new aniview bid adapter

* Support new aniview bid adapter

* Support new aniview bid adapter

* Support new aniview bid adapter

* Fix Consent parameters

* Update aniviewBidAdapter.js

V3 support

* Update aniviewBidAdapter.js

* Update aniviewBidAdapter.js

Update refererInfo

* Update aniviewBidAdapter.js

Fix tabs and spaces

* Update aniviewBidAdapter.js

fixes

* Update aniviewBidAdapter.js

* Update aniviewBidAdapter.js

Add ccpa support

* Update aniviewBidAdapter.js

Typo

* Update aniviewBidAdapter.js

* Update aniviewBidAdapter.js

* Fix size and sample

Fixed sizes from playerSize
Updated md sample

* Fix tabs

* Fix sizes

* Recheck

* Add tgt parameter

* Update sample

* Add support for cookie sync + tests

* Add support for cookie sync + tests

* Add support for cookie sync + tests

* Support aliases

Support aliases

* Update

Update

* Fix lint

Fix lint

* Update spec

Update spec

* Aniview Bid Adapter: Added the new alias

* Aniview Bid Adapter: Added the new configs for the renderer

* Aniview Bid Adapter: Added unit tests for the renderer

* Aniview Bid Adapter: Have added gvlid

* Aniview Bid Adapter: added meta.advertiserDomains to bidResponse and extended cookie sync logic

* Support BANNER mediaType

Support BANNER mediaType

* Aniview BANNER support

Fix spaces

* Aniview Bid Adapter: add a new alias and update the doc

* Aniview Bid Adapter: add a new alias

Co-authored-by: Itay Nave <itay@aniview.com>
Co-authored-by: Itay Nave <38345760+itaynave@users.noreply.github.com>

* TheMediaGrid, TrustX: fix sync url workflow (#7812)

* Added TheMediaGridNM Bid Adapter

* Updated required params for TheMediaGridNM Bid Adapter

* Update TheMediGridNM Bid Adapter

* Fix tests for TheMediaGridNM Bid Adapter

* Fixes after review for TheMediaGridNM Bid Adapter

* Add support of multi-format in TheMediaGrid Bid Adapter

* Update sync url for grid and gridNM Bid Adapters

* TheMediaGrid Bid Adapter: added keywords adUnit parameter

* Update TheMediaGrid Bid Adapter to support keywords from config

* Implement new request format for TheMediaGrid Bid Adapter

* Fix jwpseg params for TheMediaGrid Bid Adapter

* Update unit tests for The Media Grid Bid Adapter

* Fix typo in TheMediaGrid Bid Adapter

* Added test for jwTargeting in TheMediaGrid Bid Adapter

* The new request format was made by default in TheMediaGrid Bid Adapter

* Update userId format in ad request for TheMediaGrid Bid Adapter

* Added bidFloor parameter for TheMediaGrid Bid Adapter

* Fix for review TheMediaGrid Bid Adapter

* Support floorModule in TheMediaGrid Bid Adapter

* Fix empty bidfloor for TheMediaGrid Bid Adapter

* Some change to restart autotests

* Fix userIds format for TheMediaGrid Bid Adapter

* Remove digitrust userId from TheMediaGrid Bid Adapter

* Protocols was added in video section in ad request for TheMediaGrid Bid Adapter

* TheMediaGrid: fix trouble with alias using

* TheMediaGridNM: fix trouble with alias

* TheMediaGrid Bid Adapter: added support of PBAdSlot module

* TheMediaGrid Bid Adapter: fix typo

* GridNM Bid Adapter: use absent in params data from mediaTypes

* GridNM Bid Adapter: fix md file + add advertiserDomains support

* TheMediaGrid and gridNM Bid Adapter: minor netRevenue fixes

* gridNM Bid Adapter updates after review

* TheMediaGrid Bid Adapter: fix keywords workflow

* fix testing and kick off lgtm again

* TheMediaGrid: added ext.bidder.grid.demandSource processing

* TheMediaGrid: added user.id from fpd cookie

* TheMediaGrid: control cookie setting via bidder config

* TheMediaGrid: use localStorage instead cookie

* TheMediaGridNM Bid Adapter: update adapter to use /hbjson endpoint

* TheMediaGridNM: fix unnecessary conditions

* TheMediaGrid: fix bug with nurl field in response

* TheMediaGrid: update test

* TheMediaGridNM: fix possible bug with nurl

* TheMediaGrid: added alias as playwire

* TheMediaGrid: added alias as adlivetech

* TheMediaGrid: fix sync url workflow

* TrustX: fix sync url worflow + remove old syncurl

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* Adomik Analytics Adapter: add key value pair (#7617)

* adomik/add_key_value

* adomik/add_key_value/spec

* Fix an issue when gdpr is undefined (#7817)

Co-authored-by: mifanich <mihail.ivanchenko@nextmillennium.io>

* Multiple Modules: fix constants JSON imports for webpack (#7800)

* Fix constants JSON imports

* kick off tests in circleci

* undo change

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* Support for FPD (and ortb2 config) (#7802)

* Invibes Bid Adapter: support for custom domainId (#7797)

* Invibes Bid Adapter - support for custom domainId

* Invibes Bid Adapter - changes according to review

* Index Exchange adapter: Webpack v5 complain about named export from JSON modules (#7774)

* fix: Webpack v5 complain about named export from JSON modules

* Index Exchange Adapter: fix "Should not import the named export 'EVENTS'.'AUCTION_DEBUG' (imported as 'EVENTS') from default-exporting module (only default export is available soon)""

Co-authored-by: Javier Marín <contacto@ideatic.net>

* Support for new size (#7828)

* FeedAd Bid Adapter: add pass through of additional bid parameters (#7814)

* added file scaffold

* added isBidRequestValid implementation

* added local prototype of ad integration

* added implementation for placement ID validation

* fixed video context filter

* applied lint to feedad bid adapter

* added unit test for bid request validation

* added buildRequest unit test

* added unit tests for timeout and bid won callbacks

* updated bid request to FeedAd API

* added parsing of feedad api bid response

* added transmisison of tracking events to FeedAd Api

* code cleanup

* updated feedad unit tests for buildRequest method

* added unit tests for event tracking implementation

* added unit test for interpretResponse method

* added adapter documentation

* added dedicated feedad example page

* updated feedad adapter to use live system

* updated FeedAd adapter placement ID regex

* removed groups from FeedAd adapter placement ID regex

* removed dedicated feedad example page

* updated imports in FeedAd adapter file to use relative paths

* updated FeedAd adapter unit test to use sinon.useFakeXMLHttpRequest()

* added GDPR fields to the FeedAd bid request

* removed video from supported media types of the FeedAd adapter

* increased version code of FeedAd adapter to 1.0.2

* removed unnecessary check of bidder request

* fixed unit test testing for old FeedAd version

* removed video media type example from documentation file

* added gvlid to FeedAd adapter

* added decoration parameter to adapter documentation

* added pass through of additional bid parameters

* IX Bid Adapter: fix for infinite loop (#7805)

* ix infinite loop fix

* moved deviceaccess check

* changed auction debug event handler

Co-authored-by: Love Sharma <love.sharma@indexexchange.com>

* Daily Hunt Bid Adapter: update prebid compliance and add adapter back (#7755)

* version update 5.X

* test case for v5.X

* review points resolution

* dailyhunt bid adapter doc update

* indentention fixes

* re-commit for doc info

Co-authored-by: shivam.pradhan <shivam.pradhan@dailyhunt.in>

* Prebid Core: after auction is held, if more bids are matched by adUnitCode next apply filter for bidId (#7736)

* if more bids are matched, filter on bidId

* go with simpler approach

* Adkernel Bid Adapter: FPD module support (#7684)

* pubGENIUS bid adapter: update url (#7835)

* BEop Bid Adapter: fix page url in request params (#7811)

* [BEOP] Fix page url in request params

* Fix test

* Update auction.js (#7825)

* Compass Adapter: add new adapter (#7798)

* add Compass Adapter

* fix

* fix

* fix

* Prebid 6.4.0 Release (#7842)

Co-authored-by: Eric Harper <eharper@rubiconproject.com>

* Increment Pre Version (#7843)

Co-authored-by: Eric Harper <eharper@rubiconproject.com>

* GPT Pre Auction: New logic options - customPreAuction & useDefaultPreAuction (#7784)

* updated new logic

* no need to export

* missed a test update

* bidderFactory import path mistake (#7836)

An error occurs :
ERROR in ./node_modules/prebid.js/modules/bliinkBidAdapter.js 15:0-63
Module not found: Error: Can't resolve 'src/adapters/bidderFactory.js'

* check if top window can be accessed before getting data from it (#7841)

* Doceree bid adaptor: New GDPR related parameters (#7815)

* Update docereeBidAdapter.md

* Update docereeBidAdapter.js

* Update docereeBidAdapter.js

* Update docereeBidAdapter.md

* Function to check gdpr consent present

* Unit test case to check if gdpr consent present

* Update docereeBidAdapter_spec.js

* Fixed build errors

* Consent management module: allow auction to continue when CMP does not respond (#7769)

This reproduces the behavior of `allowAuctionWithoutConsent` when a TCFv2 CMP times out.
https://github.com/prebid/Prebid.js/issues/7156

* Loglylift Bid Adapter: add new bid adapter (#7761)

* make buildRequests

* remove useless code

* change ENDPOINTN_URL

* add spec test

* format code

* fix serverResponse

* add test

* add overview

* fix the bid adpter to adapt the actual response

* treat adspotId as integer

* add getUserSyncs

* add serverResponses.length > 0 on 'if' condition

* fix typo

* use test adspotId which has a test ad

* fix prebidJsVersion test

* adapt advertiserDomains

* addd GPID support (#7838)

Co-authored-by: Love Sharma <love.sharma@indexexchange.com>

* Limelight Bid Adapter: add field user id as eids to payload (#7858)

* Add userIdAsEids field

* Add tests userIdAsEids field

* kick off tests

Co-authored-by: dbelousov <dbelousov@lineate.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* Pass runner up bid from livewrapped wrapper (#7854)

* ZetaGlobal SSP Analytics Adapter: add new analytics adapter (#7790)

* Zeta Global SSP Analytics Adapter

* Trigger the build

* Trigger the build

* OptimeraRTD Module: Expose non-ad related data to the page. (#7849) (#7850)

* siteId to string (#7818)

Co-authored-by: Love Sharma <love.sharma@indexexchange.com>

* IX Bid Adapter: Add support for ID5, Lotame Panorama ID, Epsilon Publisher Link, Audigent Halo ID, SharedID (#7809)

* add id5, lotame panorama id, epsilon publink, audigent halo id

* add sharedId + diagnostics for pubProvidedId

Co-authored-by: Amy Yang <amy.yang@indexexchange.com>

* Prebid Core: mergeConfig and mergeBidderConfig functions (#7396)

* Finished mergeConfig and mergeBidderConfig functions with unit test coverage

* Added a unit test for array duplication edge case and modified mergeDeep

* Fixed LGTM alerts and merge conflicts

* Fixed readConfig export and package-lock

* Fixing tests

* Fixed circle ci errors

* restore package-lock file

* pull master package-lock file to untrack

* add globals for merge and mergeBidder

* renamed flag variable

Co-authored-by: Patrick Loughrey <ploughrey@rubiconproject.com>
Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>
Co-authored-by: bretg <bgorsline@gmail.com>

* Adyoulike bidder: improve robustness to multiple mediatypes (#7863)

* add required clickurl in every native adrequest

* allows the native response to be given as is to prebid if possible

* add unit tests on new Native case

* Handle meta object in bid response with default addomains array

* fix icon retrieval in Native case

* Update priorities in case of multiple mediatypes given

* improve robustness and fix associated unit test on picture urls

* add support for params.size parameter

* add unit test on new size format

* Makes sure the playerSize format is consistent

* enable Vast response on bidder adapter

* fix lint errors

* add test on Vast format case

* add userId to bidrequest

* revert package-lock.json changes

* improve multiple mediatype handling

* Ozone Bid Adapter: Support schain module (#7856)

* ozone 2.7.0 adapter updates

* ozone 2.7.0 - removed multiple-empty-lines to pass upstream circleci tests

* ozone 2.7.0 adapter bugfix - unused variable assignment

* ozone 2.7.0 - removed multiple-empty-lines to pass upstream circleci tests

* ozone 2.7.0 - typo fix

* ozone 2.7.0 - removed newline

Co-authored-by: Afsheen Bigdeli <afsheenb@namecast.net>

* Prebid 6.5.0 Release

* Increment pre version

* Logly Lift Bid Adapter_spec: Fix test (#7869)

Version changes as package.json does

* Bliink Bid Adapter: Add support gdprApplies when consent string does not exist (#7860)

* feat(adapter): Add bliink bid adapter

* feat(tests): Add tests unit file

* refactor: code optimisation and fix cookie sync

* fix(bliinkAdapter): get meta value

* update: Update documentation bliinkBidAdapter.md

* update: Fix sizes in buildBid function

* fix: step build

* Revert "fix: step build"

This reverts commit 9a746f5a175190ddd209f6f51bd71946a5575fe7.

* fix: step build

* fix: step build

* fix: step build

* fix: tests units

* fix: js doc

* fix: tests units

* fix: Fix build Circle CI

* fix: Fix build Circle CI

* fix: Fix build Circle CI

* fix: Fix build Circle CI

* fix: Fix build Circle CI

* fix: Fix build Circle CI

* fix: Fix build Circle CI

* fix: fix path when import registerBidder module

* Update bliinkBidAdapter.js

* fix: gdprApplies and consentString update

* fix: test units gdprApplies and consentString

Co-authored-by: Jonathan <jonathan@bliink.io>
Co-authored-by: samuel.kerboeuf <samuel@bliink.io>

* Fix prebid issue #7156 (#7876)

Co-authored-by: francesco <f.orazini@onetag.com>

* id Import Library: update with more params to capture email (#7772)

* Updating IdImportLibrary with more parameters to get email ids

* Updating IdImportLibrary with more parameters to get email ids

* Updating unit test for IdImportLibrary

Co-authored-by: skocheri <skocheri@rubiconproject.com>

* Adomik Analytics Adapter: update sampling (#7846)

* AdomikAnalyticsAdapter sampling

* kick off tests

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* showheroes-bs Bid Adapter: refactoring + fix test (#7882)

* add ShowHeroes Adapter

* ShowHeroes adapter - expanded outstream support

* Revert "ShowHeroes adapter - expanded outstream support"

This reverts commit bfcdb913b52012b5afbf95a84956b906518a4b51.

* ShowHeroes adapter - expanded outstream support

* ShowHeroes adapter - fixes (#4222)

* ShowHeroes adapter - banner and outstream fixes (#4222)

* ShowHeroes adapter - description and outstream changes (#4222)

* ShowHeroes adapter - increase test coverage and small fix

* ShowHeroes Adapter - naming convention issue

* Mixed AdUnits declaration support

* ITDEV-4723 PrebidJS adapter support with SupplyChain module object

* ITDEV-4723 Fix tests

* ITDEV-4723 New entry point

* showheroes-bsBidAdapter: Add support for advertiserDomains

* showheroes-bsBidAdapter: hotfix for outstream render

* showheroes-bsBidAdapter: update renderer url

* showheroes-bsBidAdapter: use only the necessary fields from the gdprConsent

Co-authored-by: veranevera <vera.yukhina@showheroes.com>
Co-authored-by: Elizaveta Voziyanova <44549195+h2p4x8@users.noreply.github.com>

* Adquery ID System: add new ID module (#7852)

* added adqueryID module

* Adquery QID module - Added missing files and fixed test

Co-authored-by: m.czerwiak <marcin.czerwiak@azagroup.eu>

* OGURY ADAPTER - adding prebid.js and ogury adapter versions (#7891)

* RTBHouse Bid Adapter: add support to channel param (#7879)

* delete log (#7892)

* Richaudience Bid Adapter: add schain to endpoint payload (#7893)

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

* PubMatic Analytics Adapter: add logging for "advertiser domain" (#7888)

* Changed net revenue to True

* Logging adomain in logger

* Handled with different variable names

* Changed string in double quotes to single quotes

Co-authored-by: Azhar <azhar@L1119.local>

* Criteo Id Module - Ensure that Criteo cookies are written only on TLD+1 domain (#7896)

* Update adkernelBidAdapter.js (#7894)

* Rise Bid Adapter: pass hp in supply schain (#7898)

* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* fixed schain hp parameter encode

* updated schain test

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: noamtzu <noamtzu@gmail.com>
Co-authored-by: Noam Tzuberi <noamtzu@users.noreply.github.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>
Co-authored-by: Inna Yaretsky <innay@ironsrc.com>

* Criteo - Bump version to 117 (#7901)

* Compass Adapter: update bid params (#7897)

* add Compass Adapter

* fix

* fix

* fix

* add endpointId

* RTD module: set targeting on onAuctionEnd event (#7877)

* Adding getAdUnitTargeting to the auctionEnd event. (#7871)

* Add test for RTD getAdUnitTargeting

Co-authored-by: mcallari <mike.callari@gmail.com>

* Improve Digital bid adapter: added support for cat and genre (#7899)

* Feature Prebid First Party Data (#2)

* HBT-166: Added PageCategory and Genre to request object from First-Party-Data

* HBT-166: Added PageCategory and Genre to request object from First-Party-Data and Rewrite Test Cases

* Update improvedigitalBidAdapter.js

Version increased

Co-authored-by: Faisal Islam <93644923+faisalvs@users.noreply.github.com>

* Welect Bid Adapter: update prebid compliance and add adapter back to master (#7776)

* readd welectBidAdapter

* readd test

* use es6 modules from utils

* Prebid Core: async submodule loading (#7861)

* async submodule loading

* add post install config

Co-authored-by: atkachov <atkachov@admixer.ua>

* Teads adapter: switch GPID logic to the new imp.ext.gpid field (#7903)

* Capture publisher-supplied first party data (#7833)

- Capture site and user level first party data
- Move bidder config params to unit-level to follow convention
- Remove account id (now captured within the placement id path)
- Remove demo flag (now enabled by setting demand source to 'demo')

Discussion that led to these changes: https://github.com/prebid/prebid.github.io/pull/3397

* creative comment injection spot reverted: (#7874)

- reverted injection point of creative comment to pre-PR 6860
- added code to reinject comment in case it was removed upon rendering

* Adman Bid Adapter: update getUserSyncs() (#7884)

* Add Adman bid adapter

* Add supportedMediaTypes property

* Update ADman Media bidder adapter

* Remove console.log

* Fix typo

* revert package-json.lock

* Delete package-lock.json

* back to original package-lock.json

* catch pbjs error

* catch pbjs error

* catch pbjs error

* log

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* remove eu url

* Update admanBidAdapter.js

add consnet to sync url

* Update admanBidAdapter.js

fix import

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

lint fix

* Update admanBidAdapter.js

check consent object data availability

* сompatible with prebid v5

* add Lotame Panorama ID

* update getUserSyncs

* fix

* fix tests

* remove package-lock.json

Co-authored-by: minoru katogi <mkatogi@gmail.com>
Co-authored-by: minoru katogi <m_katogi@hotmail.com>
Co-authored-by: ADman Media <admanmedia@users.noreply.github.com>
Co-authored-by: SmartyAdman <adman@localhost.localdomain>

* NextMillennium Bid Adapter: refresh_count variable moved to into ext (#7904)

* moved into ext

* added space

* updated test file with new refresh_count location

* Tappx Bid Adapter: fix adtypes bug (#7905)

* Tappx :: Adtypes bug :: solved

* Tappx ::Mimes param is not mandatory now

* Circle CI :: Aesthetic changes

* Test hotfix :: Mimes is not mandatory now

* Tappx :: Mimes is not longer mandatory

* Tappx :: Remove mimes references. Is not mandatory

Co-authored-by: Albert Grandes <agrandes@tappx.com>

* Prebid 6.6.0 Release

* increment pre version

* Kargo Bid Adapter: Fix issue with double-array for advertiserDomains (#7910)

* Fix issue with double-array for advertiserDomains

* Updated test to reflect correct advertiserDomains rray

* clickUrl to pull first advertiserDomain

* Colossus Bid Adapter: update bid params (#7907)

* add video&native traffic colossus ssp

* Native obj validation

* Native obj validation #2

* Added size field in requests

* fixed test

* fix merge conflicts

* move to 3.0

* move to 3.0

* fix IE11 new URL issue

* fix IE11 new URL issue

* fix IE11 new URL issue

* https for 3.0

* add https test

* add ccp and schain features

* fix test

* sync with upstream, fix conflicts

* Update colossussspBidAdapter.js

remove commented code

* Update colossussspBidAdapter.js

lint fix

* identity extensions

* identity extensions

* fix

* fix

* fix

* fix

* fix

* add tests for user ids

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* add gdpr support

* add gdpr support

* id5id support

* Update colossussspBidAdapter.js

add bidfloor parameter

* Update colossussspBidAdapter.js

check bidfloor

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter_spec.js

* use floor module

* Revert "use floor module"

This reverts commit f0c5c248627567e669d8eed4f2bb9a26a857e2ad.

* use floor module

* update to 5v

* fix

* add uid2 and bidFloor support

* fix

* add pbadslot support

* fix conflicts

* add onBidWon

* refactor

* add test for onBidWon()

* fix

* add group_id

* Trigger circleci

Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com>

* Prebid Core: fix typeerror from reading properties of undefined ('getSlotElementId') (#7890)

* fix: Webpack v5 complain about named export from JSON modules

* Index Exchange Adapter: fix "Should not import the named export 'EVENTS'.'AUCTION_DEBUG' (imported as 'EVENTS') from default-exporting module (only default export is available soon)""

* fix: Uncaught TypeError: Cannot read properties of undefined (reading 'getSlotElementId')

* fix: Uncaught TypeError: Cannot read properties of undefined (reading 'getSlotElementId')

Co-authored-by: Javier Marín <contacto@ideatic.net>

* Gumgum Bid Adapter: fix failing test (#7913)

* Gumgum - ADTS-174-Fix-failing-Prebid-JS-test

* removed extra line to fix lint issue

Co-authored-by: John Bauzon <john.bauzon@gumgum.com>

* Sharethrough Bid Adapter: Add First Party Data and Outstream Support (#7857)

* [PGE-178206477] Ingest First Party Data and send to Ad Server

* Use nullish

* [PGE-178206515] Allow outstream video

* Fix ortb2 usage in specs

* seeding Alliance Bid Adapter: no bids and netRevenue bugfix (#7919)

* add seedingAlliance Adapter

* add two native default params

* ...

* ...

* seedingAlliance Adapter: add two more default native params

* updating seedingAlliance Adapter

* seedingAlliance Adapter

* quickfix no bids + net revenue

Co-authored-by: Jonas Hilsen <hilsen@seeding-alliance.de>

* AdHash Bidder Adapter: minor changes (#7920)

We're operating on a com TLD now.
Added publisher in URL for easier routing.

* AdbookPSP adapter updated with support of multiple Private Auction GAM Orders (#7924)

Co-authored-by: Ankur <ankur.p@isocrates.com>

* Synacormedia bid adapter: add support for floors module (#7682)

* issue 6465 add support for floors module

* issue 6465 fix typo

Co-authored-by: rajkumar.natarajan <rajkumar.natarajan@synacor.com>

* RTD module: log submodules on init (#7922)

Addresses https://github.com/prebid/Prebid.js/issues/7883

* Colossus Bid Adapter: fix validator (#7926)

* add video&native traffic colossus ssp

* Native obj validation

* Native obj validation #2

* Added size field in requests

* fixed test

* fix merge conflicts

* move to 3.0

* move to 3.0

* fix IE11 new URL issue

* fix IE11 new URL issue

* fix IE11 new URL issue

* https for 3.0

* add https test

* add ccp and schain features

* fix test

* sync with upstream, fix conflicts

* Update colossussspBidAdapter.js

remove commented code

* Update colossussspBidAdapter.js

lint fix

* identity extensions

* identity extensions

* fix

* fix

* fix

* fix

* fix

* add tests for user ids

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* add gdpr support

* add gdpr support

* id5id support

* Update colossussspBidAdapter.js

add bidfloor parameter

* Update colossussspBidAdapter.js

check bidfloor

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter_spec.js

* use floor module

* Revert "use floor module"

This reverts commit f0c5c248627567e669d8eed4f2bb9a26a857e2ad.

* use floor module

* update to 5v

* fix

* add uid2 and bidFloor support

* fix

* add pbadslot support

* fix conflicts

* add onBidWon

* refactor

* add test for onBidWon()

* fix

* add group_id

* Trigger circleci

* fix

Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com>

* Integration examples: update the AMP creative (#7911)

* fixing the AMP creative

There's no way the original version of this ever worked. AMP requires calling out to Prebid Cache. The original example was calling for Prebid.js, which isn't present in an AMP environment. 

I just copied the instructions at https://docs.prebid.org/adops/setting-up-prebid-for-amp-in-dfp.html

* added quotes

* Generic viewability module: add new module (#7643)

* - custom viewability core

* - IntersectionObserver implementation

* - support different type of trackers

* - viewability tests wip

* - increase test coverage for viewability

* - move viewability module js

* - remove uneccesary changes

* - allow uncomplete observers to be registered again

* - import explicitly from utils

* - add viewability.md

* - add module name to log messages

* update for higher legibility

* change maintainer email (#7930)

* Compass Adapter: fix validator (#7931)

* add Compass Adapter

* fix

* fix

* fix

* add endpointId

* fix

* RTD module: allow submodules to setBidRequestData without `waitForIt` (#7862)

This change allows all RTD submodules at least one shot to see the `setBidRequestData` hook even if they are not flagged `waitForIt` (previously they would not be run at all in some cases).

Addresses https://github.com/prebid/Prebid.js/issues/7117

* Pilotx Bid Adapter: add new bid adapter (#7816)

* adding pilotx bid adapter and tests

* removing commented code

* appending review changes

Co-authored-by: AnthonyBoozan <tony@pilotx.tv>

* handle weird advertiserDomain scenarios (#7908)

* Gnet Bid Adapter: Change endpoint and add parameter (#7934)

* Add files via upload

* Add files via upload

* Change params on gnetBidder

* ADJ - Use parseSizesInput to get sizes
ADJ - Check serverResponse object
ADJ - Remove getUserSyncs function

* ADJ - Change prebid endpoint

* ADJ - Change endpoint on test

* GnetBidAdapter update for Prebid 5.x

* Change endpoint and add parameter

* import only used function from utils

Co-authored-by: Roberto Hsu Wu <hsuroberto@gmail.com>
Co-authored-by: Roberto Hsu <roberto.wu@grumft.com>
Co-authored-by: Denise Balesteros Silva <denise.balesteros@grumft.com>

* JwPlayer RTD module: Write to oRTB content segments (#7886)

* adds example code

* enriches the ortb2 object

* resolves build errors

* tests content id and data getters

* respects data integrity

* updates documentation

* Prebid 6.7 Release

* Increment pre version

* Prebid core & currency module: fix race condition on slow fetch of currency conversion file (#7851)

The currency module hooks into the auction's `addBidResponse` flow to modify bid responses with currency info. To do this it needs to fetch conversion rates from the network, but the auction expects `addBidResponse` to complete synchronously, and things break down if all bidder network calls complete before the currency file fetch.

This fix allows the `addBidResponse` hook to return a promise. If it does, the auction will wait for it before ending.

Addresses https://github.com/prebid/Prebid.js/issues/7765

* Brandmetrics RTD Module: add new RTD module (#7756)

* First version of brandmetrics RTD- module

* Implement brandmetricsRtdProvider

* Add gdpr and usp consent- checks

* Add user- consent related tests

* Set targeting keys in a more generic way

* Test- logic updates

* Criteo - Add schain support (#7940)

* updates for Prebid v5 (#7878)

* Adagio: remove referrer. reachedTop validation (#7939)

* Gumgum - ADTS-175 Support multiple GG params (#7932)

* Expose vendor ID for TCFv2 enforcement (#7927)

Co-authored-by: slimkrazy <sam@slimkrazy.com>

* displayio bid adapter, tests, doc (#7906)

Co-authored-by: Anna Philippova <annyphilippova@gmail.com>

* Core: fix pbjs.validateAdUnitPos() to handle 0 value (#7944)

Ortb2 spec uses the value `0` for "unknow" position.

* Sovrn Bid Adaptter: add video to Sovrn adapter (#7929)

* Add video to Sovrn adapter

* Update sovrnBidAdapter.js

* Update sovrnBidAdapter.md

* Update sovrnBidAdapter.md

Co-authored-by: Maxim Pakhomov <70204615+maximpakhomov@users.noreply.github.com>

* Undertone bid adapter: support for floors module (#7914)

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

 * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* fix lint issue in undertone adapter spec

* added user sync function to undertone adapter

* * Update undertone adapter - change parameters - placementId parameter is now optional and not mandatory - undertoneBidAdapter.js

* Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js

* added user sync function to undertone adapter

* added user sync function to undertone adapter

* revert package-lock.json

* added user sync function to undertone adapter

* Update undertoneBidAdapter.js

* Update browsers.json

* bidfloor support

* package-lock.json master

* bidfloor support

Co-authored-by: omerko <omer.koren@perion.com>
Co-authored-by: Omer Koren <omerko@users.noreply.github.com>
Co-authored-by: AnnaPerion <annat@perion.com>
Co-authored-by: Oran Hollaender <oran@perion.com>
Co-authored-by: tamirnPerion <44399211+tamirnPerion@users.noreply.github.com>

* InteractiveOffers - New fields and remap on the internal object (#7946)

* appnexus bid adapter - add support for auction level keywords (#7951)

* Prebid core: accept and propagate AD_RENDER_FAILED / AD_RENDER_SUCCEEDED events from cross-origin ads (#7917)

* Prebid core: accept and propagate AD_RENDER_FAILED / AD_RENDER_SUCCEEDED events from cross-origin ads

This adds a new type of cross-origin message ('Prebid Event') to allow PUC and other cross-origin renderings to correctly report rendering result, and generates the appropriate events.

Addresses https://github.com/prebid/Prebid.js/issues/7702

Related PUC changes: https://github.com/prebid/prebid-universal-creative/pull/152
Documentation changes TBD

* Emit AD_RENDER_FAILED on x-origin communication errors

* Do not consider bid won if x-origin render fails

* Cleanup (address https://github.com/prebid/Prebid.js/pull/7917#pullrequestreview-856914369)

* Prebid 6.8.0 Release

* Increment pre version

* LunamediaHB Bid Adapter: add user syncs (#7950)

* initial

* initial

* initial

* Update lunamediahbBidAdapter.js

Define traffic type by mediatype property

* Update lunamediahbBidAdapter.md

Remove unnecessary parameter

* Update lunamediahbBidAdapter_spec.js

Test for usage of mediatype for traffic definition

* Update lunamediahbBidAdapter.md

* Update lunamediahbBidAdapter.js

fix native parse

* Update lunamediahbBidAdapter_spec.js

* rever native changes

* remove traffic param

* remove traffic param

* remove traffic param

* add video context handling

* add video context handling

* add userSync

* fix

* fix

Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>

* Improve Digital COPPA support (#7948)

Co-authored-by: Samiul Amin Shanto <93644987+samiul-shanto@users.noreply.github.com>

* pass along the order which bidders were called (#7947)

* feat: add aseal bid adapter and test (#7937)

* Richaudience Bid Adapter: uncaught error on non-gdpr locations #7955 (#7962)

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>

* 'Ogury Bid Adapter: adding location to bid timeout tracks (#7961)

* Weborama RTD submodule: add support to more bid adapters (#7912)

* update .submodules.json to include weborama rtd

update .submodules.json to include weborama rtd submodule

* add support to pubmatic

* improve test format

* improve test format ~

* add support to appnexus/xandr bidder

* fix issue when split set target in two steps: site and user centric data

* add support to rubicon old style

* fix code, update docs

* add support to global and bid ortb2

* remove unused code

* refactor code

* update bidder list

* add global level parameters

* change error to warning

* update doc

* refactor

* add field accountId

* update example

* refactor js concat string

* refactor js concat string 2

* update jsdoc

* correct jsdoc

* add support to pubmatic

* improve test format

* improve test format ~

* add support to appnexus/xandr bidder

* fix issue when split set target in two steps: site and user centric data

* add support to rubicon old style

* fix code, update docs

* add support to global and bid ortb2

* remove unused code

* refactor code

* update bidder list

* add global level parameters

* change error to warning

* update doc

* refactor

* add field accountId

* update example

* refactor js concat string

* refactor js concat string 2

* update jsdoc

* correct jsdoc

* fix log

* update example

* remove todo

* refactor duplicated code in config normalization

* fix jsdoc

* add onData callback

* add unit tests and update docs

* fix doc

* protect onData callback and refactor code

* add new fields

* fix condition

* Prebid Core: refactor bidderSettings to have only one entry point (#7712)

* Refactor bidderSettings to have only one entry point

Add thin wrapper around `$$PREBID_GLOBAL$$.bidderSettings` that reduces some duplicate logic around fallback to `bidderSettings.standard`

* Do not return direct reference to a global array

* Fix bug where result of auction.js/getPriceByGranularity would ignore per-bid granularity after the first call

* Remove redundant utils.deepMerge, move utils unit tests

* Attempt to trick codacy into being a little less helpful

* Use class syntax

* Remove caching of standard adServerTargeting

* Convert recent 'allowZeroCpmBids' to new bidderSettings api

* ogury-adapter: fix some check conditions - US/non-GDPR issue (#7967)

* Conversant adapter support for first party data through the ortb2 and ortb2Imp options (#7966)

* Prebid core: accept MessageChannel communication from cross-origin creatives (#7953)

Accept MessageChannel ports from cross-origin creatives to allow communication with frames behind opaque origins

Addresses https://github.com/prebid/Prebid.js/issues/7870

* PBjs Core - Adloader : add brandmetrics module to approved external js- loaders (#7949)

* First version of brandmetrics RTD- module

* Implement brandmetricsRtdProvider

* Add gdpr and usp consent- checks

* Add user- consent related tests

* Set targeting keys in a more generic way

* Test- logic updates

* Add brandmetrics to approved external js- loaders

* Rise Bid Adapter: support onbid won (#7958)

* add Rise adapter

* fixes

* change param isOrg to org

* Rise adapter

* change email for rise

* fix circle failed

* bump

* bump

* bump

* remove space

* Upgrade Rise adapter to 5.0

* add onBidWon event

* nurl

* add test

* eslint

* fix corcle

* fix circle

* fix

Co-authored-by: Noam Tzuberi <noam.tzuberi@ironsrc.com>
Co-authored-by: Laslo Chechur <laslo.chechur@ironsrc.com>

* Prebid 6.9.0 Release

* Increment pre version

* Hadron Id Submodule: initial release & deprecate Halo Id submodule (#7938)

* rename audigent halo to hadron

* revert package-lock changes

* re-add halo modules for continuity til Prebid 7 deprecation

* revert SSP adapter changes, add halo RTD test

* remove hadron refs from ssp tests

* add contact blurb

* pull hadron from ix bid adapter

* pull hadron from tappx test

* re-add halo id system spec

* Trustpid User ID Module: initial release (#7945)

* feature: Add trustpid user id module

* refactor: Update trustpidSystem module, comments and md file

* refactor: Update trustpidSystem file to handle domain setting regardless of message events

* refactor: Update trustpidSystem module and dependent tests and docs

* refactor: Update trustpid undefined checks and returns

* tests: Update trustpid tests

* docs: Update trustpid docs typo

* refactor: Update trustpid module with storage and logging utils. Adjust tests.

Co-authored-by: Tomasz Januszek <tomasz@teavaro.com>

* Update malltvBidAdapter.md (#7973)

Changing maintainer of bid adapter

* YieldOne Bid Adapter: add IMID support. (#7982)

* PubMatic Bid Adapter : Added support for considering video params from mediaTypes object of Bid (#7980)

* Changed net revenue to True

* Checking for video params in mediaTypes obj of bid

* Added addiotional check for mediaTypes

* Added test cases

Co-authored-by: Azhar <azhar@L1119.local>

* Multiple Adapters & Modules: replace corejs polyfills with simpler stubs (#7942)

* Replace core-js polyfills with simpler stubs

* Update allowedModules / validateImports

* Move stubs to their own package to keep npm imports working without changes

* Vibrant Media Bid Adapter: add new bid adapter (#7824)

* Fluct Bid Adapter: ie polyfill 4 url search params

* more specific import

* see if corejs is white listed

* update to pure core js

* update link

* change format

* add to whitelist

* fix path to web

* add features path

* update path

* drop web in path

* fix path

* try again

* update to root

* Preliminary draft of Vibrant Prebid Adapter

* Refactoring to conform to Prebid.js data structures; Added "bid timeout" and "bid won" handlers

* Added prebid server response parser; Improved request checks; Improved test data in readme; Added URL to data passed to the server; Added tests

* Improved handling of URL sent to the server

* Removed getUserSyncs function (not needed yet); Added support for sizes property outside mediaTypes object; Added mediaSizes property support for video mdias type; Corrected readme ad unit and request examples;

* Added support for native; Added native tests; Cleaned up TODOs and logging

* Corrected prebid service URL and default currency; Bid request transformer now more resilient to different request formats; Added native ad unit to example prebid service request in the readme; Added and improved unit tests

* Removed overly-restrictive ad unit size requirements

* Updated adapter to allow a list of bids; Coding standards improvements

* Major changes to reflect the server now returning data in largely the Prebid structure; Simplified augmenting ad bids with additional required data. (Four tests fail; video renderer still a work in progress)

* Updated render (still work in progress); Fixed failing tests

* Corrected the prebid endpoint

* Removed unnecessary custom video renderer

* Added 'test-' to start of test ad unit codes

* Tweaked example in readme

* Removed debug lines and data; Code clean-up

* Improved description and corrected contact email in readme

* Updated example ad requests in the readme

* Final version of readme example; Improved bid request transform in adapter

* Resolved issues with code style and tests; Reverted package-lock

* Fixed missing comma in allowed modules array

* Fixed failing tests

* Resolved issues with code style and tests; Reverted package-lock

* Fix: Bidder code does not match adapter name

* Added USP consent support

* Changes to clarify company name

Co-authored-by: Chris Huie <phoenixtechnerd@gmail.com>

* sspBC Bid Adapter: improvee native support , matching site/placement, & other maintenance (#7963)

* Update tests for sspBC adapter

Update tests for sspBC adapter:
- change userSync test (due to tcf param appended in v4.6)
- add tests for onBidWon and onTimeout

* [sspbc-adapter] 5.3 updates: content-type for notifications

* [sspbc-adapter] pass CTA to native bid

* [sspbc-5.3] keep pbsize for detected adunits

* [sspbc-5.3] increment adaptor ver

* [sspbc-adapter] maintenance update to sspBCBidAdapter

* remove yarn.lock

* Delete package-lock.json

* remove package-lock.jsonfrom pull request

* [sspbc-adapter] send pageViewId in request

* [sspbc-adapter] update pageViewId test

* [sspbc-adapter] add viewabiility tracker to native ads

* [sspbc-adapter] add support for bid.admNative property

* [sspbc-adapter] ensure that placement id length is always 3 (improves matching response to request)

* [sspbc-adapter] read publisher id and custom ad label, then send them to banner creative

* [sspbc-adapter] adlabel and pubid are set as empty strings, if not present in bid response

* [sspbc-adapter] jstracker data fix

* [sspbc-adapter] jstracker data fix

* [sspbc-adapter] send tagid in notifications

* [sspbc-adapter] add gvlid to spec; prepare getUserSyncs for iframe + image sync

* [sspbc-adapter] fix notification payload

* [sspbc-adapter] fix notification payload, fix tests

* [sspbc-adapter] add userIds to ortb request

* [sspbc-adapter] update to 4.1, change request to be ortb 2.6 compliant

* [sspbc-adapter] update tests

Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>

* Bump log4js from 6.3.0 to 6.4.1 (#7988)

Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.1.
- [Release notes](https://github.com/log4js-node/log4js-node/releases)
- [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md)
- [Commits](https://github.com/log4js-node/log4js-node/compare/v6.3.0...v6.4.1)

---
updated-dependencies:
- dependency-name: log4js
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump shelljs from 0.8.4 to 0.8.5 (#7987)

Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5.
- [Release notes](https://github.com/shelljs/shelljs/releases)
- [Changelog](https://github.com/shelljs/shelljs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/shelljs/shelljs/compare/v0.8.4...v0.8.5)

---
updated-dependencies:
- dependency-name: shelljs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump trim-off-newlines from 1.0.1 to 1.0.3 (#7986)

Bumps [trim-off-newlines](https://github.com/stevemao/trim-off-newlines) from 1.0.1 to 1.0.3.
- [Release notes](https://github.com/stevemao/trim-off-newlines/releases)
- [Commits](https://github.com/stevemao/trim-off-newlines/compare/v1.0.1...v1.0.3)

---
updated-dependencies:
- dependency-name: trim-off-newlines
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump cached-path-relative from 1.0.2 to 1.1.0 (#7979)

Bumps [cached-path-relative](https://github.com/ashaffer/cached-path-relative) from 1.0.2 to 1.1.0.
- [Release notes](https://github.com/ashaffer/cached-path-relative/releases)
- [Commits](https://github.com/ashaffer/cached-path-relative/commits)

---
updated-dependencies:
- dependency-name: cached-path-relative
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update nextMillenniumBidAdapter.js (#7972)

Fixed an error that occurred if one of the intermediate objects response.body.ext.responsetimemillis is missing

* DSPx adapter: add pbver, pref, mediatypes, pcode (#7964)

Co-authored-by: Alexander <avj83@list.ru>

* add a configurable "bidCacheFilterFunction" (#7993)

* add a configurable "bidCacheFilterFunction" to determine whether to use a cached bid

* tiny != changed to !==

Co-authored-by: Eric Harper <eharper@rubiconproject.com>

* [SPY-10745] fixing value for 'at' ad request field for first price model (#7996)

* Mediasquare Adapter - add gvlid (#7970)

* PBS Adapter: allow "extra" bids that are not tied to any request (#7885)

* Explicitly import / setup PBS adapter test dependencies

* Allow "unknown" bidders inside PBS adapter

* Remove code duplication around processNativeAdUnitParams

* Add transactionId to bid response; make requestId optional

* Remove call to bidFactory#createBid from Telaria bid adapter

* Auction index

* Convert bid response validaton to use auctionIndex

* WIP: allow auction to work with optional bid requests (missing - fix pbjs_api_spec.js)

* Allow auction to work with optional requestId

* Remove getBidderRequest

* Mass adapter

* Fix priceFloors for optional requestId

* Add s2sConfig.allowUnknownBidderCodes toggle

* Fix lint

* Fix lint

* Fix use of auction.getProperties (use getAuctionStart instead)

* Fix lint

* Fix LGTM alert

* Adnuntius Bid Adapter: update on no cookies parameter (#7875)

* Added option to pass a user id through ortb2.

* RTD provider added.

* check if use cookie is present in config, and use it accordingly.

* Adding test for no cookie url addition.

* Adnuntius RTD Provider tests added

* Adnuntius RTD Module

* Removed adnuntius RTD provider from this pull request.

* Fix error

* Adnuntius rtd provider: initial release (#7902)

* Added option to pass a user id through ortb2.

* RTD provider a…
  • Loading branch information
Show file tree
Hide file tree
Showing 1,075 changed files with 128,820 additions and 99,938 deletions.
12 changes: 2 additions & 10 deletions .babelrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,8 @@ module.exports = {
[
useLocal('@babel/preset-env'),
{
"targets": {
"browsers": [
"chrome >= 61",
"safari >=8",
"edge >= 14",
"ff >= 57",
"ie >= 11",
"ios >= 8"
]
}
"useBuiltIns": "entry",
"corejs": "3.13.0"
}
]
],
Expand Down
23 changes: 23 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,23 @@ jobs:
from: build/dist/prebid.js
to: '"$UPLOAD_DEST"'
arguments: --cache-control 'max-age=86400'
build_v6:
<<: *environment
steps:
- checkout
- run: echo "export UPLOAD_DEST='s3://embedproduction/files/instbid-$(git describe --tags).js'" >> "$BASH_ENV"
- restore_cache: *restore_dep_cache
- run: npm install
- save_cache: *save_dep_cache
- run: *install
- run:
name: Build Prebid.js version 6
command: gulp build --modules=modules.json
- aws-s3/copy:
from: build/dist/prebid.js
to: '"$UPLOAD_DEST"'
arguments: --cache-control 'max-age=86400'


workflows:
version: 2
Expand All @@ -61,3 +78,9 @@ workflows:
branches:
only:
- master
- build_v6:
context: org-aws
filters:
branches:
only:
- prebid6
11 changes: 11 additions & 0 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
ARG VARIANT="12"
FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:${VARIANT}

# [Optional] Uncomment this section to install additional OS packages.
# RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
# && apt-get -y install --no-install-recommends <your-package-list-here>

RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | sudo apt-key add -
RUN echo "deb http://dl.google.com/linux/chrome/deb/ stable main" > /etc/apt/sources.list.d/google.list
RUN apt update
RUN apt install -y google-chrome-stable xvfb
27 changes: 27 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
// https://github.com/microsoft/vscode-dev-containers/tree/main/containers/javascript-node
{
"name": "Ubuntu",

"build": {
"dockerfile": "Dockerfile",
"args": { "VARIANT": "12" }
},

"postCreateCommand": "bash .devcontainer/postCreate.sh",

// Set *default* container specific settings.json values on container create.
"settings": {},


// Add the IDs of extensions you want installed when the container is created.
"extensions": [
"nickdodd79.gulptasks"
],

// 9999 is web server, 9876 is karma
"forwardPorts": [9876, 9999],

// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
"remoteUser": "node"
}
6 changes: 6 additions & 0 deletions .devcontainer/postCreate.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
echo "Post Create Starting"

nvm install
nvm use
npm install gulp-cli -g
npm ci
74 changes: 42 additions & 32 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,50 +1,60 @@

const allowedModules = require("./allowedModules");
const allowedModules = require('./allowedModules.js');

module.exports = {
"env": {
"browser": true,
"commonjs": true
env: {
browser: true,
commonjs: true
},
"settings": {
"import/resolver": {
"node": {
"moduleDirectory": ["node_modules", "./"]
settings: {
'import/resolver': {
node: {
moduleDirectory: ['node_modules', './']
}
}
},
"extends": "standard",
"plugins": [
"prebid",
"import"
extends: 'standard',
plugins: [
'prebid',
'import'
],
"globals": {
"$$PREBID_GLOBAL$$": false
globals: {
'$$PREBID_GLOBAL$$': false,
'BROWSERSTACK_USERNAME': false,
'BROWSERSTACK_KEY': false
},
"parserOptions": {
"sourceType": "module"
// use babel as parser for fancy syntax
parser: '@babel/eslint-parser',
parserOptions: {
sourceType: 'module',
ecmaVersion: 2018,
},
"rules": {
"comma-dangle": "off",
"semi": "off",
"space-before-function-paren": "off",
"import/extensions": ["error", "ignorePackages"],

rules: {
'comma-dangle': 'off',
semi: 'off',
'space-before-function-paren': 'off',
'import/extensions': ['error', 'ignorePackages'],

// Exceptions below this line are temporary, so that eslint can be added into the CI process.
// Violations of these styles should be fixed, and the exceptions removed over time.
//
// See Issue #1111.
"eqeqeq": "off",
"no-return-assign": "off",
"no-throw-literal": "off",
"no-undef": 2,
"no-useless-escape": "off",
"no-console": "error"
eqeqeq: 'off',
'no-return-assign': 'off',
'no-throw-literal': 'off',
'no-undef': 2,
'no-useless-escape': 'off',
'no-console': 'error'
},
"overrides": Object.keys(allowedModules).map((key) => ({
"files": key + "/**/*.js",
"rules": {
"prebid/validate-imports": ["error", allowedModules[key]]
overrides: Object.keys(allowedModules).map((key) => ({
files: key + '/**/*.js',
rules: {
'prebid/validate-imports': ['error', allowedModules[key]]
}
}))
})).concat([{
// code in other packages (such as plugins/eslint) is not "seen" by babel and its parser will complain.
files: 'plugins/*/**/*.js',
parser: 'esprima'
}])
};
29 changes: 17 additions & 12 deletions PR_REVIEW.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## Summary

We take PR review seriously. Please read https://medium.com/@mrjoelkemp/giving-better-code-reviews-16109e0fdd36#.xa8lc4i23 to understand how a PR review should be conducted. Be rational and strict in your review, make sure you understand exactly what the submitter's intent is. Anyone in the community can review a PR, but a Prebid Org member is also required. A Prebid Org member should take ownership of a PR and do the initial review.

If the PR is for a standard bid adapter or a standard analytics adapter, just the one review from a core member is sufficient. The reviewer will check against [required conventions](http://prebid.org/dev-docs/bidder-adaptor.html#required-adapter-conventions) and may merge the PR after approving and confirming that the documentation PR against prebid.org is open and linked to the issue.
Expand All @@ -11,14 +12,15 @@ General gulp commands include separate commands for serving the codebase on a bu

- Run `gulp review-start`, adding the host parameter `gulp review-start --host=0.0.0.0` will bind to all IPs on the machine
- A page will open which provides a hub for common reviewer tools.
- If you need to manually acceess the tools:
- If you need to manually access the tools:
- Navigate to build/coverage/lcov-report/index.html to view coverage
- Navigate to integrationExamples/gpt/hellow_world.html for basic integration testing
- The hello_world.html and other exampls can be edited and used as needed to verify functionality
- The hello_world.html and other examples can be edited and used as needed to verify functionality

### General PR review Process

- All required global and bidder-adapter rules defined in the [Module Rules](https://docs.prebid.org/dev-docs/module-rules.html) must be followed. Please review these rules often - we depend on reviewers to enforce them.
- Checkout the branch (these instructions are available on the github PR page as well).
- Checkout the branch (these instructions are available on the GitHub PR page as well).
- Verify PR is a single change type. Example, refactor OR bugfix. If more than 1 type, ask submitter to break out requests.
- Verify code under review has at least 80% unit test coverage. If legacy code doesn't have enough unit test coverage, require that additional unit tests to be included in the PR.
- Verify tests are green in Travis-ci + local build by running `gulp serve` | `gulp test`
Expand All @@ -29,13 +31,14 @@ General gulp commands include separate commands for serving the codebase on a bu
- If the change results in needing updates to docs (such as public API change, module interface etc), add a label for "needs docs" and inform the submitter they must submit a docs PR to update the appropriate area of Prebid.org **before the PR can merge**. Help them with finding where the docs are located on prebid.org if needed.
- If all above is good, add a `LGTM` comment and, if the change is in PBS-core or is an important module like the prebidServerBidAdapter, request 1 additional core member to review.
- Once there are 2 `LGTM` on the PR, merge to master
- The [draft release](https://github.com/prebid/Prebid.js/releases) notes are managed by [release drafter](https://github.com/release-drafter/release-drafter). To get the PR added to the release notes do the steps below. A github action will use that information to build the release notes.
- The [draft release](https://github.com/prebid/Prebid.js/releases) notes are managed by [release drafter](https://github.com/release-drafter/release-drafter). To get the PR added to the release notes do the steps below. A GitHub action will use that information to build the release notes.
- Adjust the PR Title to be appropriate for release notes
- Add a label for `feature`, `maintenance`, `fix`, `bugfix` or `bug` to categorize the PR
- Add a semver label of `major`, `minor` or `patch` to indicate the scope of change
- Add a SemVer label of `major`, `minor` or `patch` to indicate the scope of change

### Reviewing a New or Updated Bid Adapter
Documentation they're supposed to be following is https://docs.prebid.org/dev-docs/bidder-adaptor.html

Documentation: https://docs.prebid.org/dev-docs/bidder-adaptor.html

Follow steps above for general review process. In addition, please verify the following:
- Verify the biddercode and aliases are valid:
Expand Down Expand Up @@ -67,14 +70,16 @@ Follow steps above for general review process. In addition, please verify the fo
- After a new adapter is approved, let the submitter know they may open a PR in the [headerbid-expert repository](https://github.com/prebid/headerbid-expert) to have their adapter recognized by the [Headerbid Expert extension](https://chrome.google.com/webstore/detail/headerbid-expert/cgfkddgbnfplidghapbbnngaogeldmop). The PR should be to the [bidder patterns file](https://github.com/prebid/headerbid-expert/blob/master/bidderPatterns.js), adding an entry with their adapter's name and the url the adapter uses to send and receive bid responses.

### Reviewing a New or Updated Analytics Adapter
Documentation they're supposed to be following is https://docs.prebid.org/dev-docs/integrate-with-the-prebid-analytics-api.html

Documentation: https://docs.prebid.org/dev-docs/integrate-with-the-prebid-analytics-api.html

No additional steps above the general review process and making sure it conforms to the [Module Rules](https://docs.prebid.org/dev-docs/module-rules.html).

Make sure there's a docs pull request

### Reviewing a New or Updated User ID Sub-Module
Documentation they're supposed to be following is https://docs.prebid.org/dev-docs/modules/userId.html#id-providers

Documentation: https://docs.prebid.org/dev-docs/modules/userId.html#id-providers

Follow steps above for general review process. In addition:
- Try running the new user ID module with a basic config and confirm it hits the endpoint and stores the results.
Expand Down Expand Up @@ -102,9 +107,11 @@ Follow steps above for general review process. In addition:
- make sure there's a docs pull request

### Reviewing a New or Updated Real-Time-Data Sub-Module
Documentation they're supposed to be following is https://docs.prebid.org/dev-docs/add-rtd-submodule.html

Documentation: https://docs.prebid.org/dev-docs/add-rtd-submodule.html

Follow steps above for general review process. In addition:

- The RTD Provider must include a `providerRtdProvider.md` file. This file must have example parameters and document a sense of what to expect: what should change in the bidrequest, or what targeting data should be added?
- Try running the new sub-module and confirm the provided test parameters.
- Confirm that the module
Expand All @@ -118,9 +125,7 @@ Follow steps above for general review process. In addition:

## Ticket Coordinator

Each week, Prebid Org assigns one person to keep an eye on incoming issues and PRs. Every Monday morning a reminder is
sent to the prebid-js slack channel with a link to the spreadsheet. If you're on rotation, please check that list each
Monday to see if you're on-duty.
Each week, Prebid Org assigns one person to keep an eye on incoming issues and PRs. Every Monday morning a reminder is sent to the prebid-js slack channel with a link to the spreadsheet. If you're on rotation, please check that list each Monday to see if you're on-duty.

When on-duty:
- Review issues and PRs at least once per weekday for new items. Encourage a 48 "SLA" on PRs/issues assigned. Aim for touchpoint once every 48/hours.
Expand Down
25 changes: 16 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
[![Build Status](https://circleci.com/gh/prebid/Prebid.js.svg?style=svg)](https://circleci.com/gh/prebid/Prebid.js)
[![Percentage of issues still open](http://isitmaintained.com/badge/open/prebid/Prebid.js.svg)](http://isitmaintained.com/project/prebid/Prebid.js "Percentage of issues still open")
[![Average time to resolve an issue](http://isitmaintained.com/badge/resolution/prebid/Prebid.js.svg)](http://isitmaintained.com/project/prebid/Prebid.js "Average time to resolve an issue")
[![Code Climate](https://codeclimate.com/github/prebid/Prebid.js/badges/gpa.svg)](https://codeclimate.com/github/prebid/Prebid.js)
[![Coverage Status](https://coveralls.io/repos/github/prebid/Prebid.js/badge.svg)](https://coveralls.io/github/prebid/Prebid.js)
[![devDependencies Status](https://david-dm.org/prebid/Prebid.js/dev-status.svg)](https://david-dm.org/prebid/Prebid.js?type=dev)
Expand Down Expand Up @@ -60,6 +59,8 @@ module.exports = {
loader: 'babel-loader',
// presets and plugins for Prebid.js must be manually specified separate from your other babel rule.
// this can be accomplished by requiring prebid's .babelrc.js file (requires Babel 7 and Node v8.9.0+)
// as of Prebid 6, babelrc.js only targets modern browsers. One can change the targets and build for
// older browsers if they prefer, but integration tests on ie11 were removed in Prebid.js 6.0
options: require('prebid.js/.babelrc.js')
}
}
Expand Down Expand Up @@ -129,16 +130,22 @@ Once setup, run the following command to globally install the `gulp-cli` package

## Build for Development

To build the project on your local machine, run:
To build the project on your local machine we recommend, running:

$ gulp serve
$ gulp serve-and-test --file <spec_file.js>

This runs some code quality checks, starts a web server at `http://localhost:9999` serving from the project root and generates the following files:
This will run testing but not linting. A web server will start at `http://localhost:9999` serving from the project root and generates the following files:

+ `./build/dev/prebid.js` - Full source code for dev and debug
+ `./build/dev/prebid.js.map` - Source map for dev and debug
+ `./build/dist/prebid.js` - Minified production code
+ `./prebid.js_<version>.zip` - Distributable zip archive
+ `./build/dev/prebid-core.js`
+ `./build/dev/prebid-core.js.map`


Development may be a bit slower but if you prefer linting and additional watch files you can also still run just:

$ gulp serve


### Build Optimization

Expand All @@ -152,7 +159,7 @@ Building with just these adapters will result in a smaller bundle which should a

**Build standalone prebid.js**

- Clone the repo, run `npm install`
- Clone the repo, run `npm ci`
- Then run the build:

$ gulp build --modules=openxBidAdapter,rubiconBidAdapter,sovrnBidAdapter
Expand Down Expand Up @@ -273,7 +280,7 @@ As you make code changes, the bundles will be rebuilt and the page reloaded auto

## Contribute

Many SSPs, bidders, and publishers have contributed to this project. [Hundreds of bidders](https://github.com/prebid/Prebid.js/tree/master/src/adapters) are supported by Prebid.js.
Many SSPs, bidders, and publishers have contributed to this project. [Hundreds of bidders](https://github.com/prebid/Prebid.js/tree/master/modules) are supported by Prebid.js.

For guidelines, see [Contributing](./CONTRIBUTING.md).

Expand Down Expand Up @@ -315,7 +322,7 @@ For instructions on writing tests for Prebid.js, see [Testing Prebid.js](http://

### Supported Browsers

Prebid.js is supported on IE11 and modern browsers.
Prebid.js is supported on IE11 and modern browsers until 5.x. 6.x+ transpiles to target >0.25%; not Opera Mini; not IE11.

### Governance
Review our governance model [here](https://github.com/prebid/Prebid.js/tree/master/governance.md).
3 changes: 2 additions & 1 deletion allowedModules.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ const sharedWhiteList = [
'core-js-pure/features/set', // ie11 supports Set but not Set#values
'core-js-pure/features/string/includes', // no ie11
'core-js-pure/features/number/is-integer', // no ie11,
'core-js-pure/features/array/from' // no ie11
'core-js-pure/features/array/from', // no ie11
'core-js-pure/web/url-search-params' // no ie11
];

module.exports = {
Expand Down
Loading

0 comments on commit 35ca949

Please sign in to comment.