This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, @aurorahunter. Thanks you for your contribution. |
Hi, @mkbhanda @aurorahunter . Thank you for your contribution. :) @aurorahunter Can you revert changes in JAVA? Such that we can merge doc changes to trunk first. For JAVA changes for Cold storage read, we can test it on cluster, then merge it without worrying about unexpected overhead or exceptions etc. |
redundant log message eliminated line 41, we ar e are not using the input argument src .. drop it from arg list?
Thank you. :) |
Hi, @aurorahunter . Please don't add any changes into adas branch. We want to merge doc changes to trunk ASAP. Here is my suggests:
|
qiyuangong
pushed a commit
that referenced
this pull request
Mar 13, 2018
Fix typos and style problem in `admin-user-guide.md`, `client-user-guide.md`, `ssm-deployment-guide.md` and `support-new-action-guide.md`. Add anchors. Thanks to @aurorahunter and @mkbhanda .
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a batch of typos and style problems in
admin-user-guide.md
,client-user-guide.md
,ssm-deployment-guide.md
andsupport-new-action-guide.md
.