Skip to content
This repository has been archived by the owner on Jan 3, 2023. It is now read-only.

SSM doc change #1597

Merged
merged 43 commits into from
Mar 7, 2018
Merged

SSM doc change #1597

merged 43 commits into from
Mar 7, 2018

Conversation

aurorahunter
Copy link
Collaborator

@aurorahunter aurorahunter commented Feb 12, 2018

Fix a batch of typos and style problems in admin-user-guide.md, client-user-guide.md, ssm-deployment-guide.md and support-new-action-guide.md.

@qiyuangong
Copy link
Contributor

Hi, @aurorahunter. Thanks you for your contribution.
Can you split this pull request, such that each pull request contains only one contribution.

@qiyuangong
Copy link
Contributor

Hi, @mkbhanda @aurorahunter . Thank you for your contribution. :)

@aurorahunter Can you revert changes in JAVA? Such that we can merge doc changes to trunk first. For JAVA changes for Cold storage read, we can test it on cluster, then merge it without worrying about unexpected overhead or exceptions etc.

redundant log message eliminated

line 41, we ar e are not using the input argument src .. drop it from arg list?
@qiyuangong
Copy link
Contributor

Thank you. :)
But this line has been changed. Can you rebase with trunk?

@qiyuangong qiyuangong changed the title s3 support and doc change SSM doc change Mar 6, 2018
@qiyuangong
Copy link
Contributor

Hi, @aurorahunter . Please don't add any changes into adas branch. We want to merge doc changes to trunk ASAP. Here is my suggests:

  1. I will revert your JAVA and POM changes and merge it to trunk and 1.3.2.
  2. After docs are merged to trunk. We need to rebase adas branch with 1.3.2 branch.
  3. Then you can add your JAVA changes and POM changes.

@qiyuangong qiyuangong merged commit 69d7905 into trunk Mar 7, 2018
qiyuangong pushed a commit that referenced this pull request Mar 13, 2018
Fix typos and style problem in `admin-user-guide.md`, `client-user-guide.md`, `ssm-deployment-guide.md` and `support-new-action-guide.md`. Add anchors.

Thanks to @aurorahunter and @mkbhanda .
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants